Uds 2211- Modal Dialog Accessibility Review by spaceperson · Pull Request #1724 · ASU/asu-unity-stack

spaceperson · 2026-06-19T19:47:15Z

Description

Checklist

Tests pass for relevant code changes

Important Reminders

Links

Bumps [@vitest/browser](https://github.com/vitest-dev/vitest/tree/HEAD/packages/browser) from 4.1.6 to 4.1.8. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/browser) --- updated-dependencies: - dependency-name: "@vitest/browser" dependency-version: 4.1.8 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.5 to 3.4.9. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.5...3.4.9) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.9 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

# [@asu/unity-react-core-v1.11.3](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-react-core-v1.11.2...@asu/unity-react-core-v1.11.3) (2026-06-18) ### Bug Fixes * **unity-react-core:** bumps @vitest/browser from 4.1.6 to 4.1.9 ([9af53fb](9af53fb))

# [@asu/app-degree-pages-v3.2.1](https://github.com/asu/asu-unity-stack/compare/@asu/app-degree-pages-v3.2.0...@asu/app-degree-pages-v3.2.1) (2026-06-18) ### Bug Fixes * **app-degree-pages:** bumps @vitest/browser from 4.1.6 to 4.1.9 ([e3ae108](e3ae108))

# [@asu/app-rfi-v3.10.1](https://github.com/asu/asu-unity-stack/compare/@asu/app-rfi-v3.10.0...@asu/app-rfi-v3.10.1) (2026-06-18) ### Bug Fixes * **app-rfi:** bumps dompurify from 3.4.5 to 3.4.10 ([f07a003](f07a003))

With SB10 upgrade, module graph changed and import behavior caused an error in html panel addon

davidornelas11 · 2026-06-22T19:57:36Z

@copilot Add an extra line space anywhere to the root readme and make the commit message chore(deps): force pipeline rebuild to force the pipeline job to rerun

Copilot · 2026-06-22T20:02:54Z

@copilot Add an extra line space anywhere to the root readme and make the commit message chore(deps): force pipeline rebuild to force the pipeline job to rerun

Addressed in commit 6eed3a9.

mlsamuelson · 2026-07-06T20:34:37Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-07-06T20:41:13Z

@copilot resolve the merge conflicts in this pull request

Resolved in commit 5ff4373.

mlsamuelson · 2026-07-06T22:09:24Z

Errors in the pipeline. Not building staging site.

davidornelas11 · 2026-07-21T23:53:38Z

@copilot Add a commit to this just to kick off the build and make it insignificant such as adding white spae to a readme. Make sure the commit follows the format chore: force rebuild

# [@asu/unity-bootstrap-theme-v2.0.0](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v1.39.7...@asu/unity-bootstrap-theme-v2.0.0) (2026-07-17) ### Bug Fixes * **unity-bootstrap-theme:** fix safari dropdown issue in tab panels ([33d209b](33d209b)) * **unity-bootstrap-theme:** todo 3.2 ([970c8e8](970c8e8)) * **unity-bootstrap-theme:** todo 3.3, changed MoreDropdown.js to fit _tabbed-panels.scss ([f55a827](f55a827)) * **unity-bootstrap-theme:** update bootstrap tabbed panels JS and styles ([bcdd640](bcdd640)) * **unity-bootstrap-theme:** update tabbed panel JS ([9123d4b](9123d4b)) * **unity-bootstrap-theme:** update tabbed panel JS ([c171ba8](c171ba8)) * **unity-bootstrap-theme:** update tabbed panel JS ([f994c24](f994c24)) * **unity-bootstrap-theme:** update tabbed panel JS and styles ([71e53af](71e53af)) * **unity-bootstrap-theme:** update tabbed panel JS to mimic react version ([72b763b](72b763b)) * **unity-react-core:** add NavControls for app-webdir-ui use ([a4fecfe](a4fecfe)) * **unity-react-core:** address tabbed panel pr comments ([5c7085b](5c7085b)) * **unity-react-core:** changes made after review ([c35491c](c35491c)) * **unity-react-core:** final design before completeing tests ([5a44c52](5a44c52)) * **unity-react-core:** scrolling feature final ([13ba723](13ba723)) * **unity-react-core:** toDo 5.1 ([50abf19](50abf19)) * **unity-react-core:** update tabbed panel logic ([084885b](084885b)) ### Features * **unity-bootstrap-theme:** tabbed panel rewrite ([299f76e](299f76e)) * **unity-bootstrap-theme:** tODO 3.1 ([934f119](934f119)) * **unity-bootstrap-theme:** todo 3.2 ([f90438c](f90438c)) ### BREAKING CHANGES * **unity-bootstrap-theme:** New html styles are relying on unity-react-core html

# [@asu/unity-react-core-v2.0.0](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-react-core-v1.11.4...@asu/unity-react-core-v2.0.0) (2026-07-17) ### Bug Fixes * **unity-bootstrap-theme:** todo 3.3, changed MoreDropdown.js to fit _tabbed-panels.scss ([f55a827](f55a827)) * **unity-bootstrap-theme:** update tabbed panel JS ([c171ba8](c171ba8)) * **unity-react-core:** 2.1 ([97fd7c0](97fd7c0)) * **unity-react-core:** 2.1 changes ([8021a59](8021a59)) * **unity-react-core:** 2.2 with changes in tabheader.jsx file ([ccc955c](ccc955c)) * **unity-react-core:** add NavControls for app-webdir-ui use ([a4fecfe](a4fecfe)) * **unity-react-core:** added scrolling feature ([9770d53](9770d53)) * **unity-react-core:** address tabbed panel pr comments ([5c7085b](5c7085b)) * **unity-react-core:** changes ([cfbc917](cfbc917)) * **unity-react-core:** changes made after review ([c35491c](c35491c)) * **unity-react-core:** final design before completing all tests ([4e70b71](4e70b71)) * **unity-react-core:** fix react more dropdown disappearing ([f76633f](f76633f)) * **unity-react-core:** fix resize issue with react tabbed panel ([e0d4eb8](e0d4eb8)) * **unity-react-core:** fix two issues in pr ([1b9fce5](1b9fce5)) * **unity-react-core:** readd stories to Typescript config ([22e8d73](22e8d73)) * **unity-react-core:** remove focus on more tabbed panel click ([080ea5c](080ea5c)) * **unity-react-core:** to do 1.2 ([20cc261](20cc261)) * **unity-react-core:** toDo 1.1 ([ba5caef](ba5caef)) * **unity-react-core:** toDo 5.1 ([50abf19](50abf19)) * **unity-react-core:** toDo 5.2 ([11c58a1](11c58a1)) * **unity-react-core:** update dropdown for tabbed panel placement ([5e2eba8](5e2eba8)) * **unity-react-core:** update tabbed panel logic ([084885b](084885b)) * **unity-react-core:** update tabbed panels markup ([aec1303](aec1303)) ### Features * **unity-react-core:** phase 4 ([2a688c5](2a688c5)) * **unity-react-core:** rewrite tabbed panels ([e20622d](e20622d)) * **unity-react-core:** tabbed Panel Rewrite ([5021fc4](5021fc4)) * **unity-react-core:** toDo 1.3 ([85b1bd9](85b1bd9)) * **unity-react-core:** tODO 2.3 ([e2452b3](e2452b3)) ### BREAKING CHANGES * **unity-react-core:** Tabbed panels have been rewritten to include a dropdown and overflow logic with a More button. This changes the fundamental behavior

…and standard color fix

…-circle and success titles

# [@asu/unity-bootstrap-theme-v2.1.0](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v2.0.0...@asu/unity-bootstrap-theme-v2.1.0) (2026-07-22) ### Bug Fixes * **unity-bootstrap-theme:** fix for linting error ([3c7c879](3c7c879)) * **unity-bootstrap-theme:** gold maroon gray and dark hover button brand standard color fix ([d44e3f5](d44e3f5)) * **unity-bootstrap-theme:** linter error fix ([6d8c839](6d8c839)) ### Features * **unity-react-core:** replaced fa-exlamation-triangle with fa-check-circle and success titles ([fc7317d](fc7317d))

# [@asu/unity-react-core-v2.1.0](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-react-core-v2.0.0...@asu/unity-react-core-v2.1.0) (2026-07-22) ### Features * **unity-react-core:** replaced fa-exlamation-triangle with fa-check-circle and success titles ([fc7317d](fc7317d))

…has position rel

# [@asu/unity-bootstrap-theme-v2.1.1](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v2.1.0...@asu/unity-bootstrap-theme-v2.1.1) (2026-07-22) ### Bug Fixes * **unity-bootstrap-theme:** fix a11y issue min btn area if container has position rel ([5c8da93](5c8da93))

Bumps [@vitest/browser](https://github.com/vitest-dev/vitest/tree/HEAD/packages/browser) from 4.1.6 to 4.1.8. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/browser) --- updated-dependencies: - dependency-name: "@vitest/browser" dependency-version: 4.1.8 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.5 to 3.4.9. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.5...3.4.9) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.9 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

* **unity-react-core:** bumps @vitest/browser from 4.1.6 to 4.1.9 ([9af53fb](9af53fb))

* **app-degree-pages:** bumps @vitest/browser from 4.1.6 to 4.1.9 ([e3ae108](e3ae108))

* **app-rfi:** bumps dompurify from 3.4.5 to 3.4.10 ([f07a003](f07a003))

mlsamuelson · 2026-07-28T20:02:28Z

@copilot resolve merge conflicts

Copilot · 2026-07-28T20:11:28Z

@copilot resolve merge conflicts

Resolved in commit d79b933.

davidornelas11 · 2026-07-28T22:38:05Z

closed for new PR

spaceperson and others added 13 commits June 16, 2026 09:57

feat(unity-react-core): escape key listener to close modals

432f0dc

feat(unity-react-core): modal role aria-modal and aria-labeledby updates

a08b69e

feat(unity-react-core): modal input focus on open

924092e

fix(app-rfi): bumps dompurify from 3.4.5 to 3.4.10

cce6995

fix(app-degree-pages): bumps @vitest/browser from 4.1.6 to 4.1.9

4abb9ad

fix(unity-react-core): bumps @vitest/browser from 4.1.6 to 4.1.9

6690e24

chore(release): 3.10.1 [skip ci]

76f2210

# [@asu/app-rfi-v3.10.1](https://github.com/asu/asu-unity-stack/compare/@asu/app-rfi-v3.10.0...@asu/app-rfi-v3.10.1) (2026-06-18) ### Bug Fixes * **app-rfi:** bumps dompurify from 3.4.5 to 3.4.10 ([f07a003](f07a003))

chore(unity-react-core): keep react-dom/server out of SB manager

45dddc7

With SB10 upgrade, module graph changed and import behavior caused an error in html panel addon

feat(unity-bootstrap-theme): modal escape key and focus element updates

034ecfb

spaceperson requested a review from a team as a code owner June 19, 2026 19:47

Copilot started work on behalf of davidornelas11 June 22, 2026 19:57 View session

chore(deps): force pipeline rebuild

6eed3a9

Copilot AI requested a review from davidornelas11 June 22, 2026 20:03

Copilot finished work on behalf of davidornelas11 June 22, 2026 20:03

Copilot started work on behalf of mlsamuelson July 6, 2026 20:35 View session

merge dev into uds-2211 and resolve conflicts

5ff4373

Copilot finished work on behalf of mlsamuelson July 6, 2026 20:41

Copilot AI requested a review from mlsamuelson July 6, 2026 20:41

spaceperson added 2 commits July 21, 2026 16:41

fix(unity-bootstrap-theme): linter format fix

13b29f8

fix(static-site): @asu/unity-react-core version update fix

aa710a2

davidornelas11 and others added 22 commits July 22, 2026 13:38

fix(unity-react-core): fix resize issue with react tabbed panel

016ab11

fix(unity-react-core): fix react more dropdown disappearing

0f75832

fix(unity-bootstrap-theme): update bootstrap tabbed panels JS and styles

df68055

fix(unity-bootstrap-theme): gold maroon gray and dark hover button br…

e049b16

…and standard color fix

feat(unity-react-core): replaced fa-exlamation-triangle with fa-check…

f45baef

…-circle and success titles

fix(unity-bootstrap-theme): fix for linting error

c8be34d

fix(unity-bootstrap-theme): linter error fix

018ccba

revert(shared): revert yarn.lock changes

45a35c3

revert(shared): revert the revert of the yarn.lock file

2e0f272

fix(static-site): @asu/unity-react-core dependency version update

2eb7b56

fix(unity-bootstrap-theme): fix a11y issue min btn area if container …

60dcba1

…has position rel

fix(unity-react-core): bumps @vitest/browser from 4.1.6 to 4.1.9

6b6cd14

chore(release): 1.11.3 [skip ci]

62f5e76

* **unity-react-core:** bumps @vitest/browser from 4.1.6 to 4.1.9 ([9af53fb](9af53fb))

chore(release): 3.2.1 [skip ci]

125740a

* **app-degree-pages:** bumps @vitest/browser from 4.1.6 to 4.1.9 ([e3ae108](e3ae108))

chore(release): 3.10.1 [skip ci]

820e237

* **app-rfi:** bumps dompurify from 3.4.5 to 3.4.10 ([f07a003](f07a003))

mlsamuelson changed the title ~~Uds 2211~~ Uds 2211- Modal Dialog Accessibility Review Jul 28, 2026

Copilot started work on behalf of mlsamuelson July 28, 2026 20:03 View session

chore: resolve merge conflicts

d79b933

Copilot finished work on behalf of mlsamuelson July 28, 2026 20:11

davidornelas11 closed this Jul 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uds 2211- Modal Dialog Accessibility Review - #1724

Uds 2211- Modal Dialog Accessibility Review#1724
spaceperson wants to merge 114 commits into
devfrom
uds-2211

spaceperson commented Jun 19, 2026 •

edited

Loading

Uh oh!

davidornelas11 commented Jun 22, 2026

Uh oh!

Copilot AI commented Jun 22, 2026

Uh oh!

mlsamuelson commented Jul 6, 2026

Uh oh!

Copilot AI commented Jul 6, 2026

Uh oh!

mlsamuelson commented Jul 6, 2026

Uh oh!

davidornelas11 commented Jul 21, 2026

Uh oh!

mlsamuelson commented Jul 28, 2026

Uh oh!

Copilot AI commented Jul 28, 2026

Uh oh!

davidornelas11 commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

spaceperson commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Important Reminders

Links

Uh oh!

davidornelas11 commented Jun 22, 2026

Uh oh!

Copilot AI commented Jun 22, 2026

Uh oh!

mlsamuelson commented Jul 6, 2026

Uh oh!

Copilot AI commented Jul 6, 2026

Uh oh!

mlsamuelson commented Jul 6, 2026

Uh oh!

davidornelas11 commented Jul 21, 2026

Uh oh!

mlsamuelson commented Jul 28, 2026

Uh oh!

Copilot AI commented Jul 28, 2026

Uh oh!

davidornelas11 commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

spaceperson commented Jun 19, 2026 •

edited

Loading