Re-enable anonymous page caching with proper cache invalidation#960
Open
sdeibel wants to merge 1 commit into
Open
Re-enable anonymous page caching with proper cache invalidation#960sdeibel wants to merge 1 commit into
sdeibel wants to merge 1 commit into
Conversation
The question detail page had caching disabled with a TODO comment
("temporary, until invalidation fix"). This restores caching for
anonymous users by:
- Setting is_cacheable back to the computed value in the question view
- Adding invalidate_cached_thread_content_html() to the Thread model,
which clears the template fragment cache for the question detail page
- Calling it from clear_cached_data() so all cache invalidation paths
(new answers, edits, comments, etc.) also clear the page cache
- Adding cache invalidation in publish_post() for post privacy toggles
- Wiring UpdateCacheMiddleware (first) and FetchFromCacheMiddleware
(last) in the settings template MIDDLEWARE
- Adding CACHE_MIDDLEWARE_ALIAS setting
Member
|
I think it's possible that this one caused the leakage of the CSRF token. The caching of this page is tricky because it has personalized content - such the CSRF token and some markup variants, depending on the user type. |
Author
|
Possibly, although I didn't run into the bug until recently so not sure if there was also a compounding issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The question detail page had caching disabled with a TODO comment ("temporary, until invalidation fix"). This restores caching for anonymous users by: