fix(verify): preserve original input_dump and previous_manifest_path in VerificationReport - #183
Open
rishiiicreates wants to merge 1 commit into
Open
rishiiicreates wants to merge 1 commit into
rishiiicreates wants to merge 1 commit into
Conversation
…in VerificationReport - Keep user-supplied input_dump and previous_manifest_path strings in VerificationReport - Use resolved Path instances internally for existence checks, file hashing, Merkle calculations, and subprocess execution - Add tests for relative path and previous manifest path retention in VerificationReport Closes AOSSIE-Org#74
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #74
verify_preprocessing() was calling Path.resolve() directly on the user-supplied input_dump and previous_manifest_path before storing them in VerificationReport. on windows (and across symlinks such as /var on macos or junction points), resolve() alters path casing and expands symlinks, which caused report.input_dump != str(original_path) and failed test_report_stores_input_dump_path.
this PR preserves the exact user-supplied path strings for VerificationReport.input_dump and VerificationReport.previous_manifest_path, while resolving the paths into separate variables for all internal operations (existence checks, hashing, merkle root calculations, manifest chain verification, and the isolated subprocess re-run).
added unit tests in Legacy/tests/test_verify.py verifying that relative input paths and previous manifest paths are preserved verbatim in the report. all 39 tests passing green.