Conversation
Move both .bazelversion files (the root module and the obr module) from 7.4.1 to 8.5.1. Bazel 8 no longer makes @platforms visible to the root module without a bazel_dep, so add platforms 1.1.0 to MODULE.bazel for the three @platforms//:incompatible references.
obr's .bazelrc set --enable_workspace only so that //external:pffft.BUILD could load: Bazel reserves the top-level "external" package in the main repository. There is no WORKSPACE file. Bazel 9 fails to load the file from that package. Move external/ to third_party/, point extensions.bzl at @obr//third_party:pffft.BUILD, drop --enable_workspace, and describe the dependencies in docs/building.md as managed through MODULE.bazel only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the Bazel pin from 7.4.1 to 8.5.1, and removes the standalone obr module's dependency on WORKSPACE mode.
Pin Bazel 8.5.1
.bazelversion(oar) andsrc/renderer/obr/obr_capi/obr/.bazelversion(standalone obr): 7.4.1 → 8.5.1.@platformswithout abazel_dep. Without one, analysis fails withNo repository visible as '@platforms' from main repositoryat the three@platforms//:incompatiblereferences insrc/renderer/obr/BUILD.bazel,src/renderer/obr/obr_capi/BUILD.bazelandtests/examples/BUILD.bazel.MODULE.bazelnow declaresbazel_dep(name = "platforms", version = "1.1.0").Build the standalone obr module without WORKSPACE
obr's
.bazelrcsetscommon --enable_workspace, but obr has noWORKSPACEfile. The flag is only there so thatextensions.bzlcan load@obr//external:pffft.BUILD, because Bazel reserves the top-levelexternalpackage in the main repository. Bazel 8 turns WORKSPACE mode off by default. With Bazel 9.2.0 the standalone obr build fails:src/renderer/obr/obr_capi/obr/external/is renamed tothird_party/(both files unchanged).extensions.bzlpoints at@obr//third_party:pffft.BUILD.--enable_workspaceis removed from obr's.bazelrc.docs/building.mdsays Bazel dependencies are managed throughMODULE.bazelonly.The oar build consumes obr as a dependency and does not change.
Verification
On macOS with Bazel 8.5.1:
bazel test //src/... //tests/... //:oar: 7 tests pass.test_hoa_lfe_renderingis skipped as target-incompatible.bazel test --define OAR_ENABLE_HOA_LFE=1 //tests/examples:test_hoa_lfe_rendering: passes.bazel test //...: all 26 tests pass.Standalone obr with Bazel 9.2.0:
//obr/ambisonic_binaural_decoder:fft_manageranalyses with this change and fails without it with the error above. The obr test targets do not analyse on Bazel 9.2.0 either way, because googletest 1.17.0 uses the nativecc_libraryrule that Bazel 9 removed.The macOS runs used an extra local toolchain dependency for Xcode 27, which is not part of this change. The CI Bazel workflow is the first run on Linux and Windows.