Question: Single-threaded?

[trevorknight]

@yilun-zhangs

Referencing the conversation on #25:

Looking at the code, outside of the OBR directory I don't see mutex or lock, so just double checking: the intention is to be called from a single thread, right?

[yilun-zhangs]

Hi @trevorknight

OAR are C language interfaces, they are not thread safe from beginning design.
Maybe, the up layer calling OAR add lock is a good choice.
Do you have any ideas, I'd like to hear your opinions?

[trevorknight]

Sorry, to be clear, I did not think multithreading was supported nor desirable.

I saw #25 and #27 and was curious.

[trevorknight]

Re-opening in case others want to discuss.

I think I would advocate for removing any vestigial mutex, but I defer to the authors.

[trsonic]

Thanks @trevorknight for re-opening this. The OBR part of OAR is designed to be called from multiple threads for the typical real-time use cases (e.g. audio plugin). We can think of disabling the locks via compiler flag if necessary. I'm happy to discuss this further.