Speed5 tools off - #5436
Open
yeqing-wu wants to merge 3 commits into
Open
Speed5 tools off#5436yeqing-wu wants to merge 3 commits into
yeqing-wu wants to merge 3 commits into
Conversation
| seq->enable_tip = seq->single_picture_header_flag ? 0 : tool_cfg->enable_tip; | ||
| seq->enable_tip_refinemv = tool_cfg->enable_tip_refinemv; | ||
| // Force TIP RefineMV/OPFL off at speed >= 5. | ||
| seq->enable_tip_refinemv = |
Contributor
There was a problem hiding this comment.
Maybe it is better to set speed related feature in one place as other speed features? By the way, I also turned this off for LC mode in set_good_speed_features_lc_dec_framesize_independent().
Contributor
Author
There was a problem hiding this comment.
Thanks @yunqingwang1.
At first, I thought that seq_params was set in av2_init_seq_coding_tools(), which is called before av2_set_speed_features_framesize_independent(). Then, seq_params is locked at the first key frame, preventing downstream readers from modifying it. However, after reviewing your LC mode code, I realized my understanding was incorrect. I will modify the code as you suggested.
Contributor
Author
There was a problem hiding this comment.
Done, modified as you suggested.
yeqing-wu
force-pushed
the
speed5_tools_off
branch
from
September 25, 2026 16:58
8cde8da to
131319c
Compare
STATS_CHANGED Anchor: c5df831 Speed 5 (cpu-used=5): FG16 CTC (33 frames, class A1 and A2, RA) Class Y Cb Cr wAvg Enc% Dec% A1 -0.03 0.19 -0.01 -0.02 98.6 100 A2 0.05 0.22 0.08 0.06 99.0 100 Avg w/o B2 0.03 0.21 0.05 0.04 98.9 100
STATS_CHANGED Anchor: c5df831 Speed 5 (cpu-used=5): FG16 CTC (33 frames, class A1 and A2, RA) Class Y Cb Cr wAvg Enc% Dec% A1 0.05 0.11 0.16 0.05 98.6 101 A2 0.04 0.18 0.30 0.06 98.2 99 Avg w/o B2 0.04 0.16 0.26 0.06 98.3 100
STATS_CHANGED Anchor: c5df831 Speed 5 (cpu-used=5): FG16 CTC (33 frames, class A1 and A2, RA) Class Y Cb Cr wAvg Enc% Dec% A1 0.71 0.66 0.45 0.70 82 86 A2 0.74 0.41 0.58 0.72 89 86 Avg w/o B2 0.73 0.48 0.54 0.71 87 86
yeqing-wu
force-pushed
the
speed5_tools_off
branch
from
September 25, 2026 17:47
131319c to
c0e03d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not squash and then merge. Let's do the rebase and keep all three commits so that we can keep the record of the BD rate results of each change.
STATS_CHANGED
Anchor: c5df831
Speed 5 (cpu-used=5): FG16 CTC (33 frames, class A1 and A2, RA)
STATS_CHANGED
Anchor: c5df831
Speed 5 (cpu-used=5): FG16 CTC (33 frames, class A1 and A2, RA)
STATS_CHANGED
Anchor: c5df831
Speed 5 (cpu-used=5): FG16 CTC (33 frames, class A1 and A2, RA)