Conversation
jkeui
force-pushed
the
VCWG-G144
branch
2 times, most recently
from
September 24, 2026 01:56
8333bcb to
7ea9dd5
Compare
The function prune_ref_by_selective_ref_frame() returned 1 for all blocks that reference restricted references. This caused WARPMV to be the only prediction mode to be considered for restricted references by the encoder, severely hindering the compression performance of restricted switch frames. Removed this limitation and set display_order_hint to REF_RESTRICTED_DOH to ensure that all now accessible prediction modes are correctly encoded. Added is_restricted checks to av2_get_refresh_frame_flags() because the display_order_hint of restricted references is always >= the current display_order_hint.
The encoder replaces key frames with switch frames in a repeating pattern, if --sframe-replace-kf is set to a non-zero value. The pattern follows this rule: --sframe-replace-kf =0: disabled --sframe-replace-kf =1: K-S-K-S…, --sframe-replace-kf =2: K-S-S-K-S-S… --sframe-replace-kf =3: …
…refreshes all RPL slots or just one
…sframe_refresh_all
1) add requirement checks to encoder and decoder 1-1) refMVbank=0 1-2) allow_intrabc=0, allow_bawp=0 if refMVbank=0 after a switch frame 1-3) oplf=0 RefineMV=0 2) add a CLI option(--sframe-conformance-option) to apply one of the requirement(constraint) to the encoder --sframe-conformance-option=0 : (default) --enable-refmvbank=0 + BAWP is disabled after a switch frame --sframe-conformance-option=1 : intraBC is disabled after a switch frame if --enable-refmvbank=1 + BAWP is disalbed after a switch frame --sframe-conformance-option=2 : --enable-opfl-refine=0 --enable-refinemv=0 Also check git@github.com:mabenjak/avm.git(Martin Benjak)'s switch_DVMR_experiments branch (commits 47a8c2c, 31b14ea)
When a switch frame is not restricted and its reference frames are not fully refreshed, a decoder crash/mismatch is expected: only a restricted switch frame's reference marking (is_restricted, sample-values-only) makes partial reference refresh well-defined. So a switch frame must either be restricted, or fully refresh its reference frames. This test exercises restricted switch frames, so set sframe_mode = 0 explicitly instead of relying on the default (sframe_mode == 1), which produced a non-restricted switch frame with default partial refresh and triggered exactly the undefined case above.
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VCWG-133 and 144 (resolve #5418)
1) add requirement checks to encoder and decoder
1-1) refMVbank=0
1-2) allow_intrabc=0, allow_bawp=0 if refMVbank=0 after a switch frame
1-3) oplf=0 RefineMV=0
2) add a CLI option(--sframe-conformance-option) to apply one of the requirement(constraint) to the encoder
--sframe-conformance-option=0 : (default) --enable-refmvbank=0 + BAWP is disabled after a switch frame
--sframe-conformance-option=1 : intraBC is disabled after a switch frame if --enable-refmvbank=1 + BAWP is disalbed after a switch frame
--sframe-conformance-option=2 : --enable-opfl-refine=0 --enable-refinemv=0
Also check git@github.com:mabenjak/avm.git(Martin Benjak)'s switch_DVMR_experiments branch (commits 47a8c2c, 31b14ea)
This branch also includes three other encoder items which can be disabled.