Remove obsolete max_intra_bsize, intra_y/uv_mode_mask speed features - #5432
Merged
urvangjoshi merged 1 commit intoSep 23, 2026
Merged
Conversation
…_mask max_intra_bsize and intra_y_mode_mask were remnants of the old non-RD path and unused in the RD search. intra_uv_mode_mask was always set to UV_INTRA_ALL across all transform sizes after the speed >= 4 assignments were removed, making the check in intra mode search a no-op. Also removes unused enum masks (INTRA_ALL, INTRA_DC_H_V, UV_INTRA_ALL, UV_INTRA_DC_H_V_CFL) and the unused max_tx_size parameter in av2_rd_pick_intra_sbuv_mode(). Code cleanup only: no change in stats.
yeqing-wu
approved these changes
Sep 23, 2026
yeqing-wu
left a comment
yeqing-wu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the cleanup, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_intra_bsize and intra_y_mode_mask were remnants of the old non-RD path and unused in the RD search. intra_uv_mode_mask was always set to UV_INTRA_ALL across all transform sizes after the speed >= 4 assignments were removed, making the check in intra mode search a no-op.
Also removes unused enum masks (INTRA_ALL, INTRA_DC_H_V, UV_INTRA_ALL, UV_INTRA_DC_H_V_CFL) and the unused max_tx_size parameter in av2_rd_pick_intra_sbuv_mode().
Code cleanup only: no change in stats.