Skip chroma RD evaluation of interpolation filter search - #5420
Conversation
|
@yunqingwang1 @urvangjoshi Please review. |
59c84ed to
822db98
Compare
|
@dikshasingh-sys : PSNR U/V do seem to have losses for A2 set, although YUV looks ok. Was similar loss seen in AV1? I see that speed feature in AV1 is enabled for speed >= 3 only. |
Please find the BD-Rate impact for the other test sets, tested on commit 12c553a using 33 frames at speed=1: The runs for the B1 and B2 test sets are currently in progress. We will update the results once they are completed. For reference, the speed feature was extended to speed >= 1 in AV1 in 212381 and below are the results for speed 1: |
Thanks @dikshasingh-sys for that info. So, looks like we see more chroma losses in AV2 (e.g. A2, A4 and A5 sets) than what's seen in AV1 -- with 1% to 1.5% encoder speed-up. I'm unclear about the trade-off, as we haven't decided the critera for chroma. |
|
Based on AV2's YUV weights, this sounds okay to me. |
The U and V loss look acceptable to me as well. |
This patch introduces the speed feature 'skip_model_rd_uv' to skip the RD evaluation of chroma planes during the interpolation filter search. The chroma predictors are built later using the best interpolation filter selected by the luma RD. This speed feature is enabled for speed >= 1. This optimization has been taken from AV1: https://aomedia-review.googlesource.com/c/aom/+/210801 Results for RA CTC, A1 17 frames, A2 33 frames, speed 1: (Anchor: [12c553a] (AOMediaCodec@12c553a)) ``` +-----+------+-------+------+-------+---------------+ |Class| Y | U | V | YUV |EncInstCount(%)| +-----+------+-------+------+-------+---------------+ | A1 | 0.01 | -0.11 |-0.21 | 0.00 | 99.3 | | A2 | 0.00 | 0.23 | 0.40 | 0.03 | 98.6 | +-----+------+-------+------+-------+---------------+ ``` STATS_CHANGED for speed >= 1 Change-Id: I0b791230d5a5cf3228653635dd0332ad401e91bc
822db98 to
fceee4f
Compare
This patch introduces the speed feature 'skip_model_rd_uv' to skip the RD evaluation of chroma planes during the interpolation filter search. The chroma predictors are built later using the best interpolation filter selected by the luma RD. This speed feature is enabled for speed >= 1.
This optimization has been taken from AV1:
https://aomedia-review.googlesource.com/c/aom/+/210801
Results for RA CTC, A1 17 frames, A2 33 frames, speed 1: (Anchor: [12c553a])
STATS_CHANGED for speed >= 1