Fix fixed partition tree building at partial superblocks - #5417
Merged
Merged
Conversation
jianj-g
force-pushed
the
fixed-part-assert
branch
2 times, most recently
from
September 18, 2026 22:01
f640677 to
8680b74
Compare
urvangjoshi
approved these changes
Sep 21, 2026
Update find_partition_size() to use AV2's half-block boundary rule ((*bh >> 1) < rows_left && (*bw >> 1) < cols_left) instead of the legacy AV1 full-block rule (*bh <= rows_left && *bw <= cols_left), matching init_allowed_partitions_for_signaling(). Also introduce av2_build_partition_tree_var_based_partitioning() for VAR_BASED_PARTITION so it does not call a function named fixed_partitioning. Bug: b/562967635
urvangjoshi
force-pushed
the
fixed-part-assert
branch
from
September 21, 2026 17:42
8680b74 to
ef69f16
Compare
urvangjoshi
pushed a commit
that referenced
this pull request
Sep 22, 2026
Fix fixed partition boundary check at partial superblocks Update find_partition_size() to use AV2's half-block boundary rule ((*bh >> 1) < rows_left && (*bw >> 1) < cols_left) instead of the legacy AV1 full-block rule (*bh <= rows_left && *bw <= cols_left), matching init_allowed_partitions_for_signaling(). Also introduce av2_build_partition_tree_var_based_partitioning() for VAR_BASED_PARTITION so it does not call a function named fixed_partitioning. Bug: b/562967635 (cherry picked from commit 3b7e176)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fixed partition boundary check at partial superblocks
Update find_partition_size() to use AV2's half-block boundary rule
((*bh >> 1) < rows_left && (*bw >> 1) < cols_left) instead of the legacy
AV1 full-block rule (*bh <= rows_left && *bw <= cols_left), matching
init_allowed_partitions_for_signaling().
Also introduce av2_build_partition_tree_var_based_partitioning() for
VAR_BASED_PARTITION so it does not call a function named fixed_partitioning.
Bug: b/562967635