Enable four six param warp winner mode

[jadhuran]

Enable four and six param warp in winner motion mode for all tid levels

Reduce winner motion mode candidates to 3

Enabled for speed 6

Results:
Anchor: 16a4fd7
RA configurations
A1 - 17 frames
A2 - 33 frames

+-------+-------+-------+------+--------+--------+--------+
| Class | Y (%) | U(%)  | V(%) | YUV(%) | Enc(%) | Dec(%) |
+-------+-------+-------+------+--------+--------+--------+
| A1    |  0.04 | -0.07 | 0.29 |   0.05 |   98.0 |   99.7 |
| A2    |  0.07 |  0.11 | 0.02 |   0.06 |   98.5 |  101.8 |
+-------+-------+-------+------+--------+--------+--------+

[yeqing-wu]

Enable four and six param warp in winner motion mode for all tid levels

Reduce winner motion mode candidates to 2

Enabled for speed 6

Results: Anchor: 16a4fd7 RA configurations A1 - 17 frames A2 - 33 frames

+-------+-------+-------+------+--------+--------+--------+
| Class | Y (%) | U(%)  | V(%) | YUV(%) | Enc(%) | Dec(%) |
+-------+-------+-------+------+--------+--------+--------+
| A1    |  0.04 | -0.07 | 0.29 |   0.05 |   98.0 |   99.7 |
| A2    |  0.07 |  0.11 | 0.02 |   0.06 |   98.5 |  101.8 |
+-------+-------+-------+------+--------+--------+--------+

In the code, the new LUT entry is num_winner_motion_modes[3] = 3, not 2. The count is 3, not 2. Thus, should the commit message say "Reduce to 3"?

[yeqing-wu]

// Disable the 4 parameter warp delta refinement during initial mode search
// and enable the same during motion mode evaluation for winner candidates.
// For speed = 2, enabled for frames with pyramid_level >= 4.
// For speed >= 3, enabled for frames with pyramid_level >= 3.
int enable_four_param_warp_in_winner_mode;

The comments in the definition of enable_four_param_warp_in_winner_mode is out of date now. Please help update it.

[jadhuran]

Enable four and six param warp in winner motion mode for all tid levels
Reduce winner motion mode candidates to 2
Enabled for speed 6
Results: Anchor: 16a4fd7 RA configurations A1 - 17 frames A2 - 33 frames

+-------+-------+-------+------+--------+--------+--------+
| Class | Y (%) | U(%)  | V(%) | YUV(%) | Enc(%) | Dec(%) |
+-------+-------+-------+------+--------+--------+--------+
| A1    |  0.04 | -0.07 | 0.29 |   0.05 |   98.0 |   99.7 |
| A2    |  0.07 |  0.11 | 0.02 |   0.06 |   98.5 |  101.8 |
+-------+-------+-------+------+--------+--------+--------+

In the code, the new LUT entry is num_winner_motion_modes[3] = 3, not 2. The count is 3, not 2. Thus, should the commit message say "Reduce to 3"?

Addressed

[jadhuran]

// Disable the 4 parameter warp delta refinement during initial mode search
// and enable the same during motion mode evaluation for winner candidates.
// For speed = 2, enabled for frames with pyramid_level >= 4.
// For speed >= 3, enabled for frames with pyramid_level >= 3.
int enable_four_param_warp_in_winner_mode;

The comments in the definition of enable_four_param_warp_in_winner_mode is out of date now. Please help update it.

I don't see this comments.

I see the following comments in the code.

// Disable the 4 parameter warp delta refinement during initial mode search
// and enable the same during motion mode evaluation for winner candidates.
// Enabled for speed >= 3.
int enable_four_param_warp_in_winner_mode;

[yeqing-wu]

// Disable the 4 parameter warp delta refinement during initial mode search
// and enable the same during motion mode evaluation for winner candidates.
// For speed = 2, enabled for frames with pyramid_level >= 4.
// For speed >= 3, enabled for frames with pyramid_level >= 3.
int enable_four_param_warp_in_winner_mode;

The comments in the definition of enable_four_param_warp_in_winner_mode is out of date now. Please help update it.

I don't see this comments.

I see the following comments in the code.

// Disable the 4 parameter warp delta refinement during initial mode search // and enable the same during motion mode evaluation for winner candidates. // Enabled for speed >= 3. int enable_four_param_warp_in_winner_mode;

On my side, it shows the comments that I copied and pasted.