Add NEON for av2_update_nbr_diagonal - #5410
Merged
urvangjoshi merged 2 commits intoSep 23, 2026
Merged
urvangjoshi merged 2 commits into
urvangjoshi merged 2 commits into
Conversation
Contributor
Author
|
@yunqingwang1 I don't want to burden you with too many review requests. Whom else would you suggest that might be willing to help review ARM NEON PRs? |
Contributor
@jjustiss-apple Please feel free to add @jianj-g as a reviewer. He is quite experienced with SIMD optimization. |
jianj-g
reviewed
Sep 17, 2026
Contributor
Author
|
Thank you @jianj-g for the careful review, I believe I've addressed everything. |
Contributor
|
@jianj-g : any other comments? |
jianj-g
approved these changes
Sep 23, 2026
Contributor
|
Pls rebase and force-push (don't create merge commit) @jjustiss-apple |
jjustiss-apple
force-pushed
the
jjustiss/neon-update-nbr-diagonal
branch
from
September 23, 2026 17:58
fcefd29 to
534f15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The av2_update_nbr_diagonal function updates context and magnitude arrays
along the diagonal scan path in trellis coded quantization. It accounts
for roughly 5% of ARM encode time at cpu-used=1.
This adds a NEON implementation that vectorizes across the 8 trellis
states using 64-bit vectors. Key techniques: vtbl1 for state-chain
table lookups, vrhadd for rounding halving adds, vsli for bit-field
packing, and an identity fast-path to skip redundant table lookups on
the common path.
Also deduplicates kTcqBaseMaxTbl from separate static definitions in the
C and AVX2 files into a single shared definition in trellis_quant.h.
Micro-benchmark results (Apple M-series, P-core):
CTC Results (RA, cpu-used=1, 33 frames, ARM):