Save complete tank waveforms in EventBuilderV2 - #394
Open
anuj-guptta wants to merge 2 commits into
Open
anuj-guptta wants to merge 2 commits into
anuj-guptta wants to merge 2 commits into
Conversation
Event building on (EventBuilding 1): - PhaseIIADCCalibrator: copy raw tank waveforms (PMT + aux) into FinishedTankEvents before removing them from the buffer; combine pieces that share a timestamp instead of overwriting them. - EBPMT: apply the VME offset correction to FinishedTankEvents. - EBSaver: save the waveforms as RawWaveformMap in the ANNIEEvent. Event building off (EventBuilding 0): - PhaseIIADCCalibrator: convert RawWaveformMap into RawADCData and RawADCAuxData for downstream hit finding. - PhaseIIADCCalibrator, PhaseIIADCHitFinder: handle events with no tank data instead of stopping with an error. Note: The PhaseIIADCCalibrator diff looks large mainly because the EventBuilding 0 branch was re-indented for readability. The actual code changes are small. Validation - Verified that the waveforms exist in boostore for a physics event (Complete 70 us window or 35000 samples). - Tested HitFinding in both EventBuilding 0 and 1 mode to verify the hits are identical. - Attaching slides for more details: https://annie-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=7006
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event building on (EventBuilding 1):
Event building off (EventBuilding 0):
Note: The PhaseIIADCCalibrator diff looks large mainly because the EventBuilding 0 branch was re-indented for readability. The actual code changes are small.
Validation
Describe your changes
Checklist before submitting your PR
newusage, there is a reason the data must be on the heapnewthere is adelete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)Additional Material
Attach any validation or demonstration files here. You may also link to relavant docdb articles.