Skip to content

Update Python scripts to save LAPPD waveforms - #388

Open
anuj-guptta wants to merge 1 commit into
ANNIEsoft:Applicationfrom
anuj-guptta:Waveforms
Open

anuj-guptta wants to merge 1 commit into
ANNIEsoft:Applicationfrom
anuj-guptta:Waveforms

Conversation

@anuj-guptta

@anuj-guptta anuj-guptta commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes

The Python scripts are used by the Steven's autoANNIE framework for automated data processing. LAPPD waveforms were previously not stored in the final ntuples. This update enables LAPPD waveforms to be saved.

Checklist before submitting your PR

  • This PR implements a single change (one new/modified Tool, or a set of changes to implement one new/modified feature)
  • This PR alters the minimum number of files to affect this change
  • If this PR includes a new Tool, a README and minimal demonstration ToolChain is provided
  • If a new Tool/ToolChain requires model or configuration files, their paths are not hard-coded, and means of generating those files is described in the readme, with examples provided on /pnfs/annie/persistent
  • For every new usage, there is a reason the data must be on the heap
  • For every new there is a delete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)

Additional Material

Attach any validation or demonstration files here. You may also link to relavant docdb articles.

@S81D

S81D commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

To me this is fine and is reflective of what is already used in the grid scripts.

However given previous discussions, I don't think these python scripts necessarily belong in ToolAnalysis. We could instead move them to https://github.com/ANNIEsoft/ANNIE_HelperScripts (just like the offset script).

@S81D S81D self-assigned this Sep 30, 2026
@anuj-guptta

Copy link
Copy Markdown
Contributor Author

To me this is fine and is reflective of what is already used in the grid scripts.

However given previous discussions, I don't think these python scripts necessarily belong in ToolAnalysis. We could instead move them to https://github.com/ANNIEsoft/ANNIE_HelperScripts (just like the offset script).

As discussed with you offline, I would move these script to autoANNIE instead, test on grid and validate if everything works as expected. Having done that, I would update this PR.

@S81D S81D added on hold and removed question labels Oct 1, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants