Fix swapped barrel PMT y positions - #387
Merged
Merged
Conversation
PMT channel IDs: 453, 455 Swapped the y positions in documentation based on Johann's finding using AmBe data. Find relevant document: https://annie-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=6280&filename=250919_wrong_AmBe_and_PMT_positions_collabMeeting.pdf&version=1
anuj-guptta
added a commit
to anuj-guptta/WCSim
that referenced
this pull request
Jul 15, 2026
PMT channel IDs: 453, 455 Swapped the y positions in documentation based on Johann's finding using AmBe data. Changes consistent with PR: ANNIEsoft/ToolAnalysis#387 Find relevant document: https://annie-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=6280&filename=250919_wrong_AmBe_and_PMT_positions_collabMeeting.pdf&version=1
marc1uk
pushed a commit
to ANNIEsoft/WCSim
that referenced
this pull request
Jul 15, 2026
* Fix swapped barrel PMT y positions PMT channel IDs: 453, 455 Swapped the y positions in documentation based on Johann's finding using AmBe data. Changes consistent with PR: ANNIEsoft/ToolAnalysis#387 Find relevant document: https://annie-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=6280&filename=250919_wrong_AmBe_and_PMT_positions_collabMeeting.pdf&version=1 * Fix typo in previous commit
dhavvval
added a commit
to dhavvval/ToolAnalysis
that referenced
this pull request
Sep 29, 2026
, ANNIEsoft#384, ANNIEsoft#361, ANNIEsoft#386, ANNIEsoft#387) into the direct-parent branch Brings the collaboration's merged PRs up to c6747a2: the PMTWaveformSim memory and time-smearing rework (ANNIEsoft#371), MCTriggernum (ANNIEsoft#380, already equivalent here), LAPPD INCOM IDs (ANNIEsoft#381, ANNIEsoft#384), PMT-only vertex reconstruction (ANNIEsoft#361), the NCQE XS data toolchain (ANNIEsoft#386) and the swapped barrel PMT 453/455 y positions in FullTankPMTGeometry.csv (ANNIEsoft#387). PMTWaveformSim follows ANNIEsoft#371 everywhere it changed the tool (TRandom3 pointer, bool TimeSmearing with the per-PMT offset_std jitter map, log levels); on top of it stay only this branch's additions: the per-tick direct/primary parent maps published to the ANNIEEvent, SetStart/EndTick, and the ConvertMapToWaveforms signature. The jitter is added before t0_ticks, so the parent maps follow the smeared time. The header's author line keeps A.Sutton, S.Doran and D. Ajana. Checked on productionv3fix world part 1 (700 events): all hit, cluster and truth branches identical to the pre-merge build; DirectParent_* differ only as much as two pre-merge runs differ from each other (SetSeed(0)), and are now identical between runs; one neutron trackID per capture 99.04 % (208 captures) before and after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMT channel IDs: 453, 455
Swapped the y positions in documentation based on Johann's finding using AmBe data.
Find relevant document:
https://annie-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=6280&filename=250919_wrong_AmBe_and_PMT_positions_collabMeeting.pdf&version=1
Describe your changes
Checklist before submitting your PR
newusage, there is a reason the data must be on the heapnewthere is adelete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)Additional Material
Attach any validation or demonstration files here. You may also link to relavant docdb articles.