build(base): bump ROCm baseline to 7.13#107
Open
MioYuuIH wants to merge 7 commits into
Open
Conversation
Collaborator
|
Hi @MioYuuIH should we also update Pytorch version to the one with ROCm 7.13.0 |
Contributor
Author
aup-learning-cloud/dockerfiles/Base/Dockerfile.rocm Lines 125 to 149 in 3013096 We are not hardcoding the PyTorch wheel URL or ROCm target here. The Dockerfile derives the wheel index from PYTORCH_WHL_TARGET / GPU_TARGET, and CI passes the target-specific values from .github/build-config.json. The package versions have also been updated to use the ROCm 7.13.0 wheel suffix:
|
Collaborator
|
@MioYuuIH Please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gfx1152build target and keep genericgfx110x/gfx120ximage targets supported.Implementation Notes
amdrocm-core-sdk7.13-<target>packages.gfx110x/gfx120xfor the ROCm SDK packages andgfx110X-all/gfx120X-allfor PyTorch wheel buckets./opt/rocmsymlink fallback is idempotent so it does not fail when the 7.13 packages already create those links throughupdate-alternatives.ROCM_SDK_TARGETtoGPU_TARGETwhile CI passes explicit values from.github/build-config.json.Validation
jq empty .github/build-config.json.github/workflows/docker-build.ymlpython3 -m unittest tests.installer.test_gpu tests.installer.test_overlaygfx110xwithROCM_SDK_TARGET=gfx110xandPYTORCH_WHL_TARGET=gfx110X-all/opt/rocm/bin/hipccexists andtorch.__version__is2.9.1+rocm7.13.0Build Docker Imagesworkflow dispatch run26497377590succeeded forbase-gpu/all