Feature/954 update rocm - #22
Open
lauri9 wants to merge 9 commits into
Open
Conversation
rocprofiler-sdk-output-library compiles SQL sources that include sqlite3.h, but bundled TheRock headers are not propagated after rocm-systems#6664. Remove once ROCm/TheRock#5868 is resolved. Co-authored-by: Cursor <cursoragent@cursor.com>
…lure. Co-authored-by: Cursor <cursoragent@cursor.com>
TheRock now stages Python sources under share/amd_smi/amdsmi without setup.py, so pip install from that directory fails after the THEROCK bump. Co-authored-by: Cursor <cursoragent@cursor.com>
Pin THEROCK_COMMIT to 48ec94d7 so rocm-libraries includes the CCCL 3.0 revert and restores TransformInputIterator/FpLimits needed by PyTorch. Existing Meson, SQLite, Tcl, and amdsmi workarounds remain required. Co-authored-by: Cursor <cursoragent@cursor.com>
lauri9
force-pushed
the
feature/954-update-rocm
branch
from
August 21, 2026 08:37
1cdf53a to
4729680
Compare
lauri9
marked this pull request as ready for review
August 25, 2026 07:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump ROCm to version 10.1.0 (pre-release).
Closes #954
Summary of changes
Bump ROCm stack.
Installation of amd-smi has changed in rocm-systems, and this is updated in the Dockerfile.
Two workarounds are needed:
Tasks
Performance
MI350X
MI300X
Verified no regressions, but not sharing a full table here as runs were completed on multiple different nodes hence not easy to compare.
Known issue - profiling
Profiling on diffusion workloads is broken on PyTorch 2.9. When PyTorch profiler enters warmup or active mode, the system stutters and gaps appear in the GPU traces. Runtimes can be up to 4x compared to benchmarking. This issue was tested to be resolved after updating to PyTorch 2.13 on the same ROCm version. The issue likely relates to rocprofiler-sdk updates or other updates lower in the stack. PyTorch 2.9 is unlikely to get a fix to support newer ROCm, as it has already fallen off the support matrix of TheRock.
The issue will be resolved by updating to a newer PyTorch stack in a later PR. Verified to be resolved on PyTorch 2.13.