feat(eval): add isolated ROCm sanitizer plugins to main - #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings the isolated ROCm sanitizer/evaluation-tool implementation from #78 onto
main.PR #78 was merged into its stacked base,
codex/quality-loop-agent, rather thanmain. Its parent PR #76 remains an open draft, so the sanitizer implementation never reached the default branch.This branch starts from the current
origin/mainand cherry-picks only the six commits belonging to #78, with-xprovenance. It intentionally excludes the stacked branch's unrelated curated-task and quality-loop commits.Conflict resolution
The first cherry-pick was reconciled with current
mainas follows:src/evaluator.py;src/scripts/docker_benchmark.shwhile excluding quality-loop-only mounts and commands;agents/quality_loop/*, because that agent is not present onmain;/.eval-tool-artifacts/to.gitignore;mainrunner cleanup while adding evaluation-tool temporary-path cleanup.Validation
git diff --check origin/main...HEADmain.py,src/eval_tools,src/evaluator.py, andtests/eval_toolsbash tests/test_docker_benchmark.shPASS: docker_benchmark runtime, agent-selection, and eval-tool isolation tests193 passed in 5.01s459 passed, 4 skipped, 1 warning in 17.47sLineage
Original PR: #78
Original commits:
844761ccfeat(eval): add isolated ROCm sanitizer plugins25c3ddcdfix: harden evaluation tools fail-closed behaviore8d594a5docs: document planned TSAN and UBSAN support7ba42fe0feat(eval): add Waitcheck and ConSan sidecarsea0d0812fix(eval): harden sanitizer startup controls6980af57test(eval): require ConSan launcher provenance