Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #288.
Summary generation currently sends both
max_tokensandmax_completion_tokens, causing strict OpenAI-compatible endpoints to return HTTP 400. Selectmax_completion_tokensfor OpenAI-compatible models and the commonmax_tokensoption for native Claude/Anthropic models, so each provider receives its supported output budget.The regression tests exercise real Eino request serialization against local HTTP fixtures for both classic and agentic paths. Both OpenAI cases fail before the fix with the reported 400 and pass afterward. Both native Claude cases retain the 4096-token summary budget instead of the model's 8192-token default. No live provider credentials are required.
Validation:
go test ./internal/multiagent -run '^TestEinoSummarization(SendsOneTokenLimit|PreservesClaudeTokenLimit)$' -count=1— failing before, passing after.go test ./internal/multiagent ./internal/openai ./internal/llm -count=1— passed.go test ./...— passed.go vet ./internal/multiagent ./internal/openai ./internal/llm— passed.gofmtandgit diff --check— passed.