mHC optimization for expansion rate 4 (flag controlled)#3890
Open
dandragona-dev wants to merge 1 commit into
Open
mHC optimization for expansion rate 4 (flag controlled)#3890dandragona-dev wants to merge 1 commit into
dandragona-dev wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
4 tasks
51c1161 to
1799cc1
Compare
75ceffb to
fa7f997
Compare
…tions and add enable_mhc_k4_shortcut feature gate
fa7f997 to
b3a8bb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When expansion rate is equal to four we don't need to do sinkhorn as we can generate the doubly-stochastic matrix by taking a random convex combination of the permutation matrices (there are 4! = 24 of them when using expansion rate 4).
Based on https://arxiv.org/pdf/2601.05732.
Tests
Just tested with unit tests, adding the gemini-review now.
Waiting to performance test it once we get baseline DeepSeek v4 numbers.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.