Client #52: Global error boundary and 404 page#82
Merged
Conversation
Collaborator
|
lgtm! reasonable changes, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Implement error handling and 404 routing for the app. Users need a graceful fallback when the app crashes, and a clear 404 page when they hit non-existent routes.
What changed
ErrorCardwith "Go home" and "Try again" (remounts via resetKey) actions.GlobalErrorBoundaryandAuthenticatedApp, so there is one visual design for all error states.ThemeProviderwraps everything so all error states (auth and runtime) are themed.AuthenticatedAppreceives theQueryClientinstance.ErrorCarddirectly. On success, mountsQueryClientProvider > GlobalErrorBoundary > App, so the boundary only covers the authenticated subtree and cannot intercept auth errors.{ path: '*', element: <NotFoundPage /> }as the last child of the AppShell route.Notes
GlobalErrorBoundaryintentionally sits insideAuthenticatedApp(not outside it) because auth failures are async and cannot be caught by an error boundary — they must be handled withuseState+try/catch. The boundary covers only runtime rendering errors after auth succeeds.Testing
Closes #52