Skip to content

Chore #53: Web client CI pipeline#69

Merged
raphael-frank merged 4 commits into
mainfrom
chore/53-web-client-ci
Jun 11, 2026
Merged

Chore #53: Web client CI pipeline#69
raphael-frank merged 4 commits into
mainfrom
chore/53-web-client-ci

Conversation

@FadyGergesRezk

@FadyGergesRezk FadyGergesRezk commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Why

PRs touching web-client/** had no dedicated CI check, so TypeScript errors, ESLint violations, and broken Vite builds could merge undetected. The existing ci-success gate also had two bugs: it used grep which treated skipped as a failure, and it only whitelisted web-client as an allowed skip — meaning backend-only PRs would fail the gate because docker-build also cascades to skipped.

What changed

  • Added changes job using dorny/paths-filter to detect web-client/** changes
  • Added typecheck step (was missing from the existing job on main)
  • Replaced pnpm test with pnpm test:coverage — runs Vitest with v8 coverage and uploads the report as a CI artifact
  • Added @vitest/coverage-v8 to devDeps and configured v8 provider + lcov reporter in vite.config.ts
  • Set passWithNoTests: true so CI stays green while the test suite is being built out
  • Added test:coverage script to package.json
  • Fixed ci-success gate: replaced broken grep -E with jq, and whitelisted both web-client and docker-build as allowed skips (docker-build cascades when web-client is path-filtered)
  • Updated web-client/.gitignore to ignore coverage/ and progress/ instead of plans/

Notes

  • SonarCloud integration is pending — needs an org admin to import the repo. Will follow up in a separate PR once the token is available.
  • docker-build must be listed as an allowed skip in ci-success because it needs: web-client — when web-client is skipped, docker-build is skipped too regardless of its own if condition.

Testing

  • Pre-commit hook ran typecheck, lint, tests, and build locally — all passed
  • CI workflow YAML validated by inspection against all acceptance criteria in the issue

Closes #53

@FadyGergesRezk FadyGergesRezk force-pushed the chore/53-web-client-ci branch from 64de344 to e763518 Compare June 7, 2026 20:01
@f-s-h f-s-h requested a review from raphael-frank June 8, 2026 09:07
@raphael-frank

Copy link
Copy Markdown
Collaborator

lgtm! thanks for the fixes!

@raphael-frank

Copy link
Copy Markdown
Collaborator

will merge and close!

@raphael-frank raphael-frank merged commit 988d0da into main Jun 11, 2026
17 checks passed
@raphael-frank raphael-frank deleted the chore/53-web-client-ci branch June 11, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chore: Web client CI pipeline

2 participants