Chore #53: Web client CI pipeline#69
Merged
Merged
Conversation
64de344 to
e763518
Compare
Collaborator
|
lgtm! thanks for the fixes! |
Collaborator
|
will merge and close! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PRs touching
web-client/**had no dedicated CI check, so TypeScript errors, ESLint violations, and broken Vite builds could merge undetected. The existingci-successgate also had two bugs: it usedgrepwhich treatedskippedas a failure, and it only whitelistedweb-clientas an allowed skip — meaning backend-only PRs would fail the gate becausedocker-buildalso cascades to skipped.What changed
changesjob usingdorny/paths-filterto detectweb-client/**changestypecheckstep (was missing from the existing job on main)pnpm testwithpnpm test:coverage— runs Vitest with v8 coverage and uploads the report as a CI artifact@vitest/coverage-v8to devDeps and configured v8 provider + lcov reporter invite.config.tspassWithNoTests: trueso CI stays green while the test suite is being built outtest:coveragescript topackage.jsonci-successgate: replaced brokengrep -Ewithjq, and whitelisted bothweb-clientanddocker-buildas allowed skips (docker-build cascades when web-client is path-filtered)web-client/.gitignoreto ignorecoverage/andprogress/instead ofplans/Notes
docker-buildmust be listed as an allowed skip inci-successbecause itneeds: web-client— when web-client is skipped, docker-build is skipped too regardless of its ownifcondition.Testing
Closes #53