Skip to content

fix: npm dev launch #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ADITYA-tp01 merged 1 commit into from
Aug 29, 2026
Merged

fix: npm dev launch #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/setup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Write-Host ""

Write-Host "[5/6] Starting the dashboard..."
Push-Location apps/dashboard
Start-Process -NoNewWindow npm -ArgumentList "run", "dev" -RedirectStandardOutput "$env:TEMP\missioncontrol-dashboard.log" -RedirectStandardError "$env:TEMP\missioncontrol-dashboard.err.log"
Start-Process powershell -ArgumentList "-NoExit", "-Command", "cd '$PWD'; npm run dev"

@qodo-code-review qodo-code-review Bot Aug 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Apostrophe breaks dashboard launch 🐞 Bug ≡ Correctness

The child command is built as cd '$PWD'; npm run dev, so a repository path containing an
apostrophe (for example, C:\Users\O'Brien\Mission-Control) produces invalid PowerShell syntax and
the dashboard never starts. Start-Process is asynchronous and the script does not validate the
child process before printing its startup message.
Agent Prompt 
## Issue description
The dashboard launch command interpolates `$PWD` inside a single-quoted PowerShell command. Paths containing apostrophes generate invalid child PowerShell syntax, so `npm run dev` does not start.

## Issue Context
The command runs while `Push-Location apps/dashboard` is active, then `Pop-Location` immediately follows. Preserve the intended dashboard working directory while avoiding unescaped path text in the child command.

## Fix Focus Areas
- scripts/setup.ps1[76-76]

Use `-WorkingDirectory` with the resolved dashboard path and pass only the npm arguments to the child process, or otherwise correctly escape/quote the path before invoking the nested PowerShell command. Ensure the startup failure is detectable rather than unconditionally reporting that the dashboard is starting.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@codeant-ai codeant-ai Bot Aug 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The dashboard is launched asynchronously without capturing the process or checking its exit status, and the fixed delay does not verify that npm run dev successfully started or bound port 3001. Dependency, compilation, or port-binding failures are therefore reported as a successful dashboard startup. Start the process with observable error handling and poll the dashboard health endpoint before claiming it is available. [incomplete implementation]

Severity Level: Major ⚠️ 
- ❌ Windows setup hides dashboard startup failures.
- ⚠️ Users receive an unusable dashboard URL.
- ⚠️ Port conflicts and Next.js failures require manual diagnosis.

Use CodeAnt Skill Fix in Cursor Fix in VSCode Claude

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** scripts/setup.ps1
**Line:** 76:76
**Comment:**
	*Incomplete Implementation: The dashboard is launched asynchronously without capturing the process or checking its exit status, and the fixed delay does not verify that `npm run dev` successfully started or bound port 3001. Dependency, compilation, or port-binding failures are therefore reported as a successful dashboard startup. Start the process with observable error handling and poll the dashboard health endpoint before claiming it is available.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

Pop-Location
Start-Sleep -Seconds 5
Write-Host " Dashboard starting on http://localhost:3001"
Expand Down