Fix loader guns firing past their ROF limit - #327
Open
KemGus wants to merge 2 commits into
Open
Conversation
The crew-loader reload clamp used DefaultReloadTime as its upper bound, so a ROFLimit (or undersized ammo) slower than the shell's physical reload inverted the clamp band and was ignored. Raise the upper bound to the fire-rate floor.
KemGus
marked this pull request as ready for review
August 2, 2026 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crew-loader reload clamp used DefaultReloadTime as its upper bound, so a ROFLimit (or undersized ammo) slower than the shell's physical reload inverted the clamp band and was ignored.
Fixes https://discord.com/channels/580463055595503646/1348767344247308429
Used claude opus 5 to fix. Confirmed the issue through prints in-code, verified in game.