Skip to content

Fix acfActive and acfSetActive commands - #320

Open
Ally-for-Hire wants to merge 2 commits into
ACE-Project-Team:devfrom
Ally-for-Hire:agent/contraption-deletion-lag-upstream
Open

Fix acfActive and acfSetActive commands#320
Ally-for-Hire wants to merge 2 commits into
ACE-Project-Team:devfrom
Ally-for-Hire:agent/contraption-deletion-lag-upstream

Conversation

@Ally-for-Hire

@Ally-for-Hire Ally-for-Hire commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Updating the always-active behavior to work with the e2 and sf functions.

## Summary

  • Persist E2 acfActive(number) and Starfall entity:acfSetActive(bool) state while an entity's Active input is unwired.
  • Keep a connected Wire source authoritative; removing the wire restores the stored command state.
  • Apply the same transition behavior to ammo, fuel tanks, engines, and default-active radar/sensor entities.
  • Preserve engine startup defaults unless an explicit E2/Starfall command establishes stored state; legality recovery also reapplies the stored or wired authority.

@Ally-for-Hire Ally-for-Hire self-assigned this Jul 31, 2026
@Ally-for-Hire
Ally-for-Hire marked this pull request as ready for review July 31, 2026 03:15
@Ally-for-Hire Ally-for-Hire added area: core Lifecycle, contraptions, legality, points, caches, or shared systems. area: integrations E2, Starfall, Wire, Lua APIs, compatibility, and external-addon integration. labels Jul 31, 2026
@Ally-for-Hire Ally-for-Hire changed the title Persist ACF Active command state Fix acfActive and acfSetActive commands Jul 31, 2026
@Ally-for-Hire

Ally-for-Hire commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@KemGus finish testing this!!!!!

KemGus
KemGus approved these changes Aug 2, 2026
View reviewed changes

@KemGus KemGus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the bug for me, good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KemGus KemGus KemGus approved these changes

Assignees

@Ally-for-Hire Ally-for-Hire

Labels

area: core Lifecycle, contraptions, legality, points, caches, or shared systems. area: integrations E2, Starfall, Wire, Lua APIs, compatibility, and external-addon integration.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ally-for-Hire @KemGus