Skip to content

Update guns in place with the ACE menu tool - #319

Open
KemGus wants to merge 3 commits into
ACE-Project-Team:devfrom
KemGus:feature/gun-update-on-click
Open

Update guns in place with the ACE menu tool#319
KemGus wants to merge 3 commits into
ACE-Project-Team:devfrom
KemGus:feature/gun-update-on-click

Conversation

@KemGus

@KemGus KemGus commented Jul 30, 2026

Copy link
Copy Markdown
Member

What does this PR do: makes it possible now to alter the model for the guns by saving entity data and preserving its constraints and links. Previously you wouldn't be able to swap your 100mm C to 120mm C, now it is possible with this.

Was manually tested in Gmod, code was also reviewed. Logic taken straight from acf-3, basically what it does according to gmod wiki is reusing what gmod basic duplicator does by saving entity data.
image

Co-authored by Opus 5

@KemGus KemGus changed the title Update guns in place with the ACF menu tool Update guns in place with the ACE menu tool Jul 30, 2026
@KemGus
KemGus force-pushed the feature/gun-update-on-click branch from 0096fe4 to dd9c56e Compare July 30, 2026 22:44
@KemGus

KemGus commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

Will bring over hydraulic stuff since acf-3 has it for a reason I assume. I guess there might be an edge case of a person using hydraulics to steer the gun.

Also those helper functions could be used for any other ace ent now.

@Ally-for-Hire Ally-for-Hire added area: core Lifecycle, contraptions, legality, points, caches, or shared systems. area: weapons Guns, racks, weapon behavior, and weapon content. labels Jul 31, 2026
@KemGus
KemGus marked this pull request as ready for review August 2, 2026 23:22
@KemGus

KemGus commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

The test failing should be fixed by @Ally-for-Hire , I don't understand why I need to add the function to the curated list for backwards compatibility if it is a new function. I might be wrong (please correct me)

@Ally-for-Hire

Copy link
Copy Markdown
Collaborator

The test failing should be fixed by @Ally-for-Hire , I don't understand why I need to add the function to the curated list for backwards compatibility if it is a new function. I might be wrong (please correct me)

will look into it

@KemGus

KemGus commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@Ally-for-Hire any update ? 🥲

@Ally-for-Hire

Copy link
Copy Markdown
Collaborator

should be outdated now, you can safely ignore that

@Ally-for-Hire

Copy link
Copy Markdown
Collaborator

small correction: will fix on dev. the test isnt necessary on new functions and already passes on old functions

@Ally-for-Hire

Copy link
Copy Markdown
Collaborator

fixed on dev, just needs to be fixed on your branch now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Lifecycle, contraptions, legality, points, caches, or shared systems. area: weapons Guns, racks, weapon behavior, and weapon content.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants