Skip to content

Make the build addon check pass #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serrebidev wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make the build addon check pass #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f184b8
Fix ruff lint violations (E711, E701, E722, F401, F841)
serrebidev Jul 16, 2026
073d9d2
Apply ruff-format and add-trailing-comma
serrebidev Jul 16, 2026
89093d9
Skip pyright in CI, as pre-commit.ci already does
serrebidev Jul 16, 2026
d3b1c86
Remove trailing blank line from readme.md
serrebidev Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build_addon.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ jobs:
uv sync

- name: Code checks
run: export SKIP=no-commit-to-branch; uv run pre-commit run --all-files
# Pyright is skipped here for the same reason .pre-commit-config.yaml skips it on
# pre-commit.ci: it needs the NVDA source tree at ../nvda/source (see the extraPaths
# setting in pyproject.toml), which is not available on the runner, so every NVDA
# import is unresolved and the hook can never pass.
run: export SKIP=no-commit-to-branch,pyright; uv run pre-commit run --all-files

- name: building addon
run: uv run scons && uv run scons pot
Expand Down
Loading