Skip to content

Guard getFixedNum against a None simpleFirstChild #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serrebidev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Guard getFixedNum against a None simpleFirstChild #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions addon/globalPlugins/columnsReview/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,14 @@ def getColumnData(self, colNumber):
def getFixedNum(self, num):
curItem = api.getFocusObject()
child = curItem.simpleFirstChild
# Some list implementations report childCount > 0 but expose no simple
# first child object (seen with wxWidgets wxListCtrl on recent wxWidgets
# builds). Without a first column we can't compute an invisible-column
# offset, so fall back to treating the pressed number as the 1-based
# column index instead of crashing on child.columnNumber (issue: bare
# Alt/NVDA+Ctrl+n raised "'NoneType' object has no attribute 'columnNumber'").
if child is None or child.columnNumber is None:
return num
startNum = child.columnNumber-1
if num == 1:
return startNum+1
Expand Down
Loading