Repository navigation
fix: debug wrapper layout; export TChartGroupLoaderProps - #18
Merged
Merged
Conversation
Every other component exports its props type - TSciChartGroupProps, ISciChartNestedLegendProps - but ChartGroupLoader's was declared locally, so consumers had no way to name it when wrapping the component or typing their own props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SciChartMemoryDebugWrapperrendered its children inside aposition: fixedbox, which collapsed percentage-based sizing and put anything below the fold out of reach of scrolling. The controls arestickynow and the children render in normal flow.TChartGroupLoaderPropsis exported, matching every other component's props type.