Fix IRC attendance query resulting in name/presence flood#313
Merged
Conversation
queryAttendance sent a query/attendance job whose target had only an id and no name. The Sockethub IRC platform builds the NAMES command from target.name, so the omission produced a bare NAMES, causing the server to return the entire network channel list and flood the connection on every join. Set name on the target, mirroring join. Closes #312 Refs sockethub/sockethub#1085
raucao
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On IRC,
queryAttendancesent a Sockethubquery/attendancejob whosetargethad only anidand noname. The Sockethub IRC platform builds theNAMEScommand fromtarget.name, so the omission produced a bareNAMES(no channel argument). IRC servers answer a bareNAMESwith the entire network channel list, flooding the connection with presence for every channel on every join.This sets
nameon the attendance target, mirroring whatjoinalready does.Closes #312
Refs sockethub/sockethub#1085