feature: m1-mcp-server added#66
Conversation
|
The installation instructions currently use pip directly. I think, it would be better to use a virtual environment, since on modern Debian/Ubuntu systems pip install often fails. |
|
@aaronmontilla Did you check all the comments by @ErikGaida ? If so, can you please resolve the conversations so we know if and how the comments have been addressed. Thank you! |
The AF responds with 202 Accepted when deleting sessions, but the code only checked for 200 and 204, causing the session state not to clear. Refs 5G-MAG#66
samplingPeriod is a required field per TS26.512 and is now a mandatory parameter. README updated to use a virtual environment to comply with PEP 668 restrictions on modern Debian/Ubuntu systems. Closes 5G-MAG#66
|
I have just made the commits to the repository. The issues reported by @ErikGaida should now be resolved. |
…6G acknowledgement - Remove MIT LICENSE file from m1-mcp-server/ (inherits 5G-MAG Public License from repo root) - Update README license section to reference 5G-MAG Public License (v1.0) - Add Agentic-6G project acknowledgement (Grant Agreement No. 101290342, SNS JU / Horizon Europe) - Fix clone URL from aaronmontilla fork to 5G-MAG/rt-common-shared
|
Hi @aaronmontilla, looking at this now I have a general question. We would like to have a "generic" MCP Server which can be configured to process:
I see now that the tools contain files related to M1. I also see that the PR is called m1-mcp-server Is there a way to keep here just the generic MCP server which can be used for any API and then put the files related to M1 in the rt-5gms-application-provider? We would then do the same for CAMARA APIs so there is a rt-camara-examples repo containing any file needed to be inserted in the generic MCP server. Does it make sense? Pinging @tlohmar in case there are comments. |
|
I would say the answer depends on the deployment we want. Pros:
Cons:
Last two are pretty easy to handle. I think that there are two questions that would make the difference here: Anyway, I think that this is worth discussing and should be clarified before making a final decision. |
|
Thanks @aaronmontilla ! Do you always need all the APIs? If not, I would create independent MCP servers. Are the APIs producing outputs that other APIs will depend on? If that is the case, we must consider to implement combined MCP server at least for the APIs with codependencies. My initial thoughts are:
The idea of having a generic server where you push different configuration options doesnt seem feasible. |
|
What I would suggest:
I put this on the agenda for Friday but we can continue discussion here |
| ## Installation | ||
|
|
||
| ```bash | ||
| git clone -b feature/m1-mcp-server https://github.com/5G-MAG/rt-common-shared.git |
There was a problem hiding this comment.
Please use the main branch here, removing -b feature/m1-mcp-server.
|
As discussed I rebased development onto main, this pull request should now only reflect the changes required for the MCP server |
m1-mcp-server version 1.0 added