Fix/sobol shortfall and init validation#23
Merged
Conversation
`AxBackend.initialize` was shrinking `num_initialization_trials` by the already-completed count, but Ax's `use_existing_trials_for_ initialization` already counts attached trials against that budget. The stack double-counted: a user asking for 5 Sobol trials got 3, and the count shrank further each cycle. Underfitted surrogate → BO locks onto boundaries. Also surfaces Ax's `DataRequiredError` (init=0 with no trials) as a clear FlowBoost ValueError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
num_already_completedshrink inAxBackend.initialize. Ax already counts attached trials toward the init budget, so stacking our shrink on top silently ran ~60% of the requested Sobol trials and starved BO's prior (the second half of Ax backend error: "Arm already exists with name … which doesn't match given arm name" when attaching trials #18).DataRequiredErrorinto a clear FlowBoostValueErrorwheninitialization_trials=0meets no attached trials.target_valuetermination.Related to #18