Remove completed Danse snapshot cleanup workflow - #2560
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedNext included review available in 52 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR removes the completed Danse snapshot cleanup workflow after run #47 verified that cleanup succeeded and one canonical Cloudflare deployment remains at source commit 2d7dd6c. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward removal of an unused one-time destructive workflow with no remaining in-repo references detected.
Pull request overview
Removes a one-time GitHub Actions workflow that performed guarded deletion of legacy Danse Cloudflare Pages deployments, now that the cleanup has completed and the remaining canonical deployment has been verified.
Changes:
- Delete
.github/workflows/prune-danse-snapshots.ymlto prevent re-running a destructive, completed cleanup workflow.
File summaries
| File | Description |
|---|---|
| .github/workflows/prune-danse-snapshots.yml | Removes the completed one-off Danse snapshot pruning workflow to eliminate accidental re-invocation risk. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15edd9a34a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,303 +0,0 @@ | |||
| name: Prune legacy Danse snapshots | |||
There was a problem hiding this comment.
Revoke reruns before removing the destructive workflow
Deleting this YAML prevents new dispatches but does not invalidate completed runs; the installed gh run rerun --help explicitly documents gh run rerun [<run-id>] as “Rerun an entire run.” While run #47 remains rerunnable, an authorized actor can execute this deleted revision with the current Cloudflare secret, and if the pinned deployment is still canonical after a new preview is created, the workflow will classify that preview as legacy and delete it. Delete the historical cleanup run(s) or otherwise make their credential unusable before treating the workflow as non-invocable.
Useful? React with 👍 / 👎.
The guarded cleanup completed in run #47 and verified one Cloudflare deployment remains, serving canonical source
2d7dd6c. Remove the one-time destructive workflow so it cannot be invoked again.Summary by Sourcery
CI: