Skip to content

Remove completed Danse snapshot cleanup workflow - #2560

Merged
4444J99 merged 1 commit into
mainfrom
chore/remove-danse-prune-workflow-20260901
Sep 1, 2026
Merged

Remove completed Danse snapshot cleanup workflow#2560
4444J99 merged 1 commit into
mainfrom
chore/remove-danse-prune-workflow-20260901

Conversation

@4444J99

@4444J99 4444J99 commented Sep 1, 2026

Copy link
Copy Markdown
Owner

The guarded cleanup completed in run #47 and verified one Cloudflare deployment remains, serving canonical source 2d7dd6c. Remove the one-time destructive workflow so it cannot be invoked again.

Summary by Sourcery

CI:

  • Remove the completed one-time Danse snapshot cleanup workflow to prevent it from being invoked again.

Copilot AI lite review requested due to automatic review settings September 1, 2026 02:09

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @4444J99, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 17 hours and 6 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T02:13:20.067569Z 15edd9a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 3a688940-7c1c-4356-85a2-f3aa8e765ccb

📥 Commits

Reviewing files that changed from the base of the PR and between 8f2ed81 and 15edd9a.

📒 Files selected for processing (1)
  • .github/workflows/prune-danse-snapshots.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR removes the completed Danse snapshot cleanup workflow after run #47 verified that cleanup succeeded and one canonical Cloudflare deployment remains at source commit 2d7dd6c.

File-Level Changes

Change Details Files
Remove the completed one-time destructive snapshot cleanup workflow to prevent it from being invoked again.
  • Delete the Danse snapshot pruning workflow and its 303 lines of implementation.
.github/workflows/prune-danse-snapshots.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@4444J99
4444J99 merged commit 26b82eb into main Sep 1, 2026
8 of 9 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a straightforward removal of an unused one-time destructive workflow with no remaining in-repo references detected.

Pull request overview

Removes a one-time GitHub Actions workflow that performed guarded deletion of legacy Danse Cloudflare Pages deployments, now that the cleanup has completed and the remaining canonical deployment has been verified.

Changes:

  • Delete .github/workflows/prune-danse-snapshots.yml to prevent re-running a destructive, completed cleanup workflow.
File summaries
File Description
.github/workflows/prune-danse-snapshots.yml Removes the completed one-off Danse snapshot pruning workflow to eliminate accidental re-invocation risk.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15edd9a34a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,303 +0,0 @@
name: Prune legacy Danse snapshots

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Revoke reruns before removing the destructive workflow

Deleting this YAML prevents new dispatches but does not invalidate completed runs; the installed gh run rerun --help explicitly documents gh run rerun [<run-id>] as “Rerun an entire run.” While run #47 remains rerunnable, an authorized actor can execute this deleted revision with the current Cloudflare secret, and if the pinned deployment is still canonical after a new preview is created, the workflow will classify that preview as legacy and delete it. Delete the historical cleanup run(s) or otherwise make their credential unusable before treating the workflow as non-invocable.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants