⚡ Optimize MicrotubuleTorus draw calls with InstancedMesh - #146
⚡ Optimize MicrotubuleTorus draw calls with InstancedMesh#146jason420247 wants to merge 1 commit into
Conversation
Co-authored-by: jason420247 <44763042+jason420247@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Optimized
MicrotubuleTorusincomponents/QuantumScene.tsxusing Three.jsInstancedMesh(<instancedMesh>) to handle batch rendering of torus instances. Matrix transformations for each element are computed insideuseFrameusing a memoizedTHREE.Object3Ddummy object and updated viasetMatrixAtandinstanceMatrix.needsUpdate = true.🎯 Why:
Previously, rendering thousands of individual
<mesh>nodes created significant GPU overhead due to an excessive number of draw calls (one draw call per cube, totaling 1080+ draw calls per frame for the scene). UtilizingInstancedMeshreduces rendering operations down to single instanced draw calls per torus component.📊 Measured Improvement:
PR created automatically by Jules for task 486312556651233101 started by @jason420247