Send a user with no organization from the welcome page to onboarding - #16
Merged
Merged
Conversation
The welcome page's "Dashboard" button, and the "Open dashboard" call to action under the headline, both fall back to "/" when the signed in user has no organization. That is the page they are already on, so the button reads as broken: nothing happens. The fallback predates onboarding. It was written when registration still created an organization for every new user, so "no organization" could not happen and "/" was as good as anywhere. When 2c77d46 stopped auto-creating organizations it pointed the sidebar at the onboarding page but left the welcome page behind; ProductSyncManager and the compliance platform updated both. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The welcome page's Dashboard button, and the Open dashboard call to action under the headline, both fall back to
/when the signed in user has no organization. That is the page they are already on, so the button reads as broken: nothing happens.The fallback predates onboarding. It was written when registration still created an organization for every new user, so "no organization" could not happen and
/was as good as anywhere. When 2c77d46 stopped auto-creating organizations it pointed the sidebar at the onboarding page but left the welcome page behind — ProductSyncManager and the compliance platform updated both, which is why this only shows up here.One line, plus a browser test that walks the path a user actually takes. Reverting the fix turns the new test red with
Actual path [/] does not equal expected path [/onboarding].🤖 Generated with Claude Code