Skip to content

Add proper JUnitTest for packeteventsSK#8

Draft
CrebsTheCoder wants to merge 7 commits into
3add:devfrom
CrebsTheCoder:feature/junit-test
Draft

Add proper JUnitTest for packeteventsSK#8
CrebsTheCoder wants to merge 7 commits into
3add:devfrom
CrebsTheCoder:feature/junit-test

Conversation

@CrebsTheCoder
Copy link
Copy Markdown
Collaborator

@CrebsTheCoder CrebsTheCoder commented Apr 22, 2026

Currently there's no way to test this without hopping in-game or launching a server. There are still many test scripts to be made untill this pr is complete.

Do not merge untill all of this is finished

  • Entity
    • effects
    • expressions
    • sections
  • General
    • effects
    • expressions
    • sections
    • stuctures
  • Simple
    • effects
    • expressions
  • Team
    • effects
    • expressions
    • sections

@CrebsTheCoder
Copy link
Copy Markdown
Collaborator Author

Can't make a test skript for entity ride because there's no expression to check that but could do smth similar by spawning an entity like 5 blocks away and check the location change

@3add
Copy link
Copy Markdown
Owner

3add commented Apr 22, 2026

Actually about ride, shouldn't we just make an expression for passengers of fake entity which you can then add/remove to it

@CrebsTheCoder
Copy link
Copy Markdown
Collaborator Author

true

…d color, billboard, block data, frozen time, glowing state, gravity, height, rotation, scale, teleport interpolation duration, and view range
Comment thread src/main/java/dev/threeadd/packeteventssk/element/entity/Types.java Outdated
@3add
Copy link
Copy Markdown
Owner

3add commented May 8, 2026

EnumWrapper is provided by SkriptRegistrationAPI, this pr also requires a lot of changes using the new systems. Most of it is reusable though.

@3add 3add marked this pull request as draft May 10, 2026 19:34
# Conflicts:
#	build.gradle
#	src/main/java/dev/threeadd/packeteventssk/element/entity/Types.java
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a2656367-b605-4bf1-9ae3-ae3ed94d8eec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

fix: use URI instead of URL (deprecated constructor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants