Fix TPMS surface discovery with Autograd 1.9 - #147
Open
kmarchais wants to merge 1 commit into
Open
Conversation
kmarchais
force-pushed
the
fix/explicit-tpms-surface-registry
branch
from
August 1, 2026 11:46
90ff995 to
9bb3dde
Compare
kmarchais
marked this pull request as ready for review
August 2, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUILTIN_SURFACEScatalog containing every built-in TPMS surface exactly oncehoneycomb_*annotations to reflect their NumPy array inputs and outputsRoot cause
Autograd 1.9.1 changed the signatures exposed by its imported
sinandcoswrappers. They now appear to have three parameters, so the tests'inspect.getmembers()plus signature-length heuristic mistakenly classified them as Microgen TPMS surfaces and invoked them with(x, y, z).Discovering the supported test matrix through module introspection was brittle because unrelated imported callables could enter it when dependency implementation details changed. The explicit
BUILTIN_SURFACEStuple makes the exhaustive built-in catalog stable and intentional while leavingTpmsfree to accept arbitrary user-provided callables.Validation
git diff --check: passedtests/shapes/test_tpms.py: 181 passed