Gsdm 41: Add Github Actions for Staging - #23
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GitHub Actions workflow for staging builds and updates the git submodule configuration to use HTTPS instead of SSH for the mobile-offline-downloader-android repository.
- Introduces a new staging CI workflow that builds Android APKs and distributes them via Firebase
- Converts submodule URL from SSH to HTTPS for better CI/CD compatibility
- Removes the unused android-vault submodule reference
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .gitmodules | Removes android-vault submodule and converts mobile-offline-downloader-android URL from SSH to HTTPS |
| .github/workflows/Staging.yml | Adds complete staging workflow with build, test, and Firebase distribution capabilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| sed -i "s/const val versionCode = [0-9]\+/const val versionCode = $VERSION_CODE/" buildSrc/src/main/java/Dependencies.kt | ||
| sed -i 's/const val versionName = "[^"]*"/const val versionName = "'"$VERSION_NAME"'"/' buildSrc/src/main/java/Dependencies.kt |
There was a problem hiding this comment.
The sed commands are modifying Dependencies.kt but the file path references 'buildSrc/src/main/java/Dependencies.kt' without the 'apps/' prefix that's used in other steps (see line 81 'cd apps'). This inconsistency suggests the working directory context may be incorrect, potentially causing the version updates to fail silently.
| sed -i "s/const val versionCode = [0-9]\+/const val versionCode = $VERSION_CODE/" buildSrc/src/main/java/Dependencies.kt | |
| sed -i 's/const val versionName = "[^"]*"/const val versionName = "'"$VERSION_NAME"'"/' buildSrc/src/main/java/Dependencies.kt | |
| sed -i "s/const val versionCode = [0-9]\+/const val versionCode = $VERSION_CODE/" apps/buildSrc/src/main/java/Dependencies.kt | |
| sed -i 's/const val versionName = "[^"]*"/const val versionName = "'"$VERSION_NAME"'"/' apps/buildSrc/src/main/java/Dependencies.kt |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| app/build/test-results | ||
| app/build/reports/tests |
There was a problem hiding this comment.
The paths reference 'app/build/' but the build is executed in 'apps/student/build/'. The correct paths should be 'apps/student/build/test-results' and 'apps/student/build/reports/tests'.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Jira: https://2u-internal.atlassian.net/browse/GSDM-41