fix: skip missing media files instead of crashing - #113
Conversation
Filter out non-existent media files before passing to genanki, so users still get their flashcards even if images are missing from the upload.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 13 minutes and 7 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Pull request overview
This PR prevents APKG generation from failing when some referenced media files are missing by filtering out non-existent media paths before passing them to genanki.Package.
Changes:
- Filter
media_filesto only include paths that exist, and emit a stderr warning for skipped entries. - Update the existing media test to create real temp files and pass absolute paths.
- Add a new test to verify missing media paths are skipped.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
helpers/write_apkg.py |
Filters missing media files before assigning package.media_files and warns on stderr. |
tests/test_write_apkg.py |
Makes media tests use real temp files/paths and adds coverage for missing media behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if len(existing_media) < len(media_files): | ||
| missing = set(media_files) - set(existing_media) |
There was a problem hiding this comment.
missing is computed via set(media_files) - set(existing_media), which collapses duplicates and produces a non-deterministic ordering. Since media_files can contain duplicates (e.g., same image referenced by multiple cards), the reported count/list can be inaccurate and confusing. Consider computing missing as an ordered list (e.g., [f for f in media_files if not os.path.exists(f)]) and using that for both the count and the message.
| if len(existing_media) < len(media_files): | |
| missing = set(media_files) - set(existing_media) | |
| missing = [f for f in media_files if not os.path.exists(f)] | |
| if missing: |
| open(existing_path, 'w').close() | ||
| media_files = [existing_path, 'image.png'] |
There was a problem hiding this comment.
This test uses a relative path ('image.png') to represent a missing media file. If a file with that name exists in the process working directory (e.g., developer machine/CI workspace), the test can become flaky. Use an absolute path inside tmpdir (e.g., os.path.join(tmpdir, 'image.png')) without creating it to guarantee it is missing.
| open(existing_path, 'w').close() | |
| media_files = [existing_path, 'image.png'] | |
| missing_path = os.path.join(tmpdir, 'image.png') | |
| open(existing_path, 'w').close() | |
| media_files = [existing_path, missing_path] |
Filter out non-existent media files before passing to genanki, so users still get their flashcards even if images are missing from the upload.