perf(macOS): scope workbench refresh and add FPS monitor - #138
Merged
Conversation
Stop caret, find, diagnostics, and project-tree updates from rebuilding the whole window. Keep file watching and Git refresh, but apply them to the surfaces that actually change. Add a status-bar FPS readout so typing jank is visible.
Button and context-menu closures are not MainActor-isolated under the CI Swift 6 check. Hop back to AppModel from nonisolated action methods instead of marking the helper class itself MainActor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macOS workbench updates were fanning out through
AppModel, so typing, caret movement, Git refresh, and language diagnostics rebuilt the whole window.This PR keeps file watching and Git refresh, but applies each event to the surfaces that actually change:
EditorChromeModelEditorDiagnosticsStoreso LSP publish storms do not rebuild the workbenchCodeEditorViewincremental: dirty-range highlight, line-index edits, deferred decorations/LSP syncHow to verify
./scripts/test-macos.shand./scripts/verify-service-boundaries.shwere run locally.Known follow-ups
AppModel.