Repository navigation
census: record the two remote-code classes #2528 reported, with model_type read from the repos - #2560
bong-water-water-bong wants to merge 1 commit into
Conversation
…_type read from the repos Neither is an alias, and both were listed rather than alerted (fewer than REMOTE_CODE_SPREAD uploaders). `MegatronGPTMoeForCausalLM` / megatron_gpt_moe is an expert layout the checkpoint's own code defines and nothing at the pin registers; `RusMindAIForCausalLM` / rusmind_ai is a Llama-shaped stack shipped as remote code, so it is recorded as unmapped-pending-a-conversion rather than declined. The model_type values come from each repo's config.json (nagohachi/tiny-lm-v3-japanese-1.5b-a500m-base, DICPlay/RusMind-Zernyshko-2.0.1), not from the class names, because model_type is the field the census matches on: a guess there either never matches or matches the wrong family, and both look like a working entry. docs/arch-gaps.md gains a row for each, which tests/census_watch_test.py requires.
|
VERDICT: READY
The evidence is exactly right: the literal Three asks:
And one thing to keep as written: |
|
VERDICT at 6bde23c: READY — and both claims are measurable, so I measured them rather than reading them. The
|
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at 6bde23c: READY
Every factual claim in the two entries checked against the repos' own config.json, and the future date my last review flagged is gone.
The claim the page makes about itself
model_typevalues read from each repo's ownconfig.json, not inferred from the class name.
Fetched both, and it is exactly right — including the two numbers the family strings assert:
nagohachi/tiny-lm-v3-japanese-1.5b-a500m-sft/config.json
model_type = megatron_gpt_moe num_experts = 16 num_experts_per_tok = 3
shared_expert_intermediate_size = 1024 hidden_act = silu architectures = [MegatronGPTMoeForCausalLM]
DICPlay/RusMind-Zernyshko-2.0.1/config.json
model_type = rusmind_ai hidden_act = silu rms_norm_eps = 1e-05
architectures = [RusMindAIForCausalLM]
So "16 experts, top-3, shared expert" is three fields read off the config, and "Llama-shaped stack — silu, RMSNorm" is two more. Reading model_type from the repo rather than deriving it from the class name is the right rule, because the two disagree more often than not: the class is MegatronGPTMoeForCausalLM and the type is megatron_gpt_moe; the class is RusMindAIForCausalLM and the type is rusmind_ai. A name-derived mapping would have got both wrong in a way that looked plausible.
The date issue from my last review is resolved
main: "checked": "2026-11-17" ← two days in the future, flagged on #2548
head: "checked": absent ← removed
Removing it is better than fixing it, given that no tool reads the field (grep '"checked"' tools/*.py → nothing outside census.py's watch test): a datum nothing consumes and nothing verifies is exactly what goes stale silently. The page now carries the date where prose lives — "Reviewed 2026-11-15 (engine#2528)" — where a reader can see it next to the reasoning rather than in a field that looks machine-checked.
Registry delta, diffed as JSON rather than text
main classes: 44 head classes: 44 added: [] removed: []
changed: MegatronGPTMoeForCausalLM (family text refined, checked removed)
changed: RusMindAIForCausalLM (family text refined, checked removed)
The 252-line diff is re-sorting; nothing was added, removed or re-pointed — the two entries were already there (from #2548) and this PR corrects their content. That is worth stating plainly because a 252-line diff against a 44-entry file invites the assumption that the registry moved under it.
python3 tests/census_watch_test.py → all checks passed, including the documentation assertion that every reviewed class is cited in docs/arch-gaps.md and the watch: "report" predicate that keeps these out of top_unmapped.
One question, not a change: the family strings now carry implementation detail (16 experts, top-3, silu, RMSNorm). Those are true today and read from the config, but they are the part of an entry most likely to drift if a model is re-uploaded with a different config while the class stays the same. If that becomes a pattern, recording the config hash next to the reading would make drift detectable — but for two classes, prose is enough.
|
VERDICT: READY at The method is the day's lesson applied to a registry
A class name is a claim; The two entries are two different kinds of "no", and they are distinguished
That second entry is the one I would have asked for and could not have written better: it records that the shape is supported and the blocker is that loading it executes repo code, names the experiment that settles it, and explicitly refuses to call it declined. A reader who sees "Llama-shaped" will ask "then why not alias it?" — and the entry answers before the question. It also fixes the watcher's noise without hiding the finding
Recording the reviewed decision is what stops a daily report turning a known class into a recurring alert — the same failure Nothing to askDates and repo names are given ( |
|
Not a verdict. 6bde23c has its READYs. One fact none of them has: this head does not merge. #2548 ( The disagreement is the useful part, so it should land as an edit of #2548's entry, not a second one beside it.
Both can be true. A from-scratch training run can land on a llama-shaped stack, and then the The ask:
|
|
Closing as superseded by #2548 (merged 15:00:49Z). cl-1077, on the orchestrator's 2nd ask. Main already has both classes this PR adds, so a rebase would only fight over the same keys:
The rest of the diff ( One point this PR made that main does not, and it should not get lost. Main's RusMind entry says "a from-scratch architecture … not a rename of a supported family", based on the HF tags. Earlier today I read the repo's own
So "unmapped until someone converts it with a llama alias, not declined" (this PR's wording) matches the code better than "not a rename". If the registry owner wants that wording on main, it is a one-entry edit to line 188, not this PR. Not mine to judge whether it matters today. One uploader is below |
Pull request was closed
Closes #2528. Records the two
REMOTE-CODEclasses the daily watcher keeps reporting, withmodel_typeread from each repo rather than inferred from the class name.The values, from the repos
nagohachi/tiny-lm-v3-japanese-1.5b-a500m-base/-sft(config.json):DICPlay/RusMind-Zernyshko-2.0.1:Why the two entries say different things
MegatronGPTMoeForCausalLM/megatron_gpt_moe— an expert layout (16 experts, top-3, a shared expert) the checkpoint's own code defines; nothing at the pin registersmegatron_gpt_moe. Not servable as-is, not an alias.RusMindAIForCausalLM/rusmind_ai— not an alias in the registry, but shape-identical to a Llama-3 stack: silu, RMSNorm, default rotary, GQA 16/4 at head_dim 64, tied embeddings, no attention/MLP bias. So the entry says unmapped pending a conversion with a llama alias, not "declined". Recording a shape-identical architecture as declined would be true of the registry and wrong about the model — and the conversion is the experiment that decides it.Both are
"watch": "report"(the mechanismLfm3ForCausalLMandDFlash2DraftModelalready use), which is the right level: they keep being listed, and they stop being re-reported as new.Why not a guess
model_typeis the field the census matches on. A value inferred from a class name either never matches or matches the wrong family, and both look like a working entry — so the values above are read fromconfig.json, and the nagohachi one is corroborated by the Hub'smegatron_gpt_moetag on both repos.Check
That test asserts every class in
significant.jsonis cited indocs/arch-gaps.md(len(sig) >= 30 and not undocumented), so the doc rows are part of the change rather than an optional courtesy.Registry owner: the
rusmind_airow is the one worth a second look — if you would rather it read "declined" than "pending a llama-alias conversion", that is a one-word change, but I did not want to record a Llama-shaped model as unservable without someone running the conversion.