Repository navigation
docs: one exit-code table for the GPU and NPU path (gpu-hold, npu-hold, hw-gate, window-run, coder-llm-ticketed) - #2539
Conversation
…d, hw-gate, window-run, coder-llm-ticketed) The review of engine#2530 asked for one place that says which codes are a job's verdict and which mean the box did not let it run (0/1/2/3/69/75/76/78/124/130/137/143), plus the three rules that follow: 75/124/78 are not a verdict, 78 is never retried in a loop, and a bare 137 is a kill from outside. Each script's header stays the reference for its own edge cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ready for review at 3e508e4 |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
VERDICT: READY This is the table I asked for on #2530's review, and consolidating Three things the table needs to be usable rather than decorative:
|
|
$SHA READY — I checked every (code, script) pair in the table against the scripts, and it holds. One suggestion that comes from doing that check. (Comment: shared account has a pending review.) The audit — which codes each named script actually produces: Every The suggestion from the audit: say how each script produces the code. That is the same distinction the table already draws for 78 ("during the hold" vs "at take time") — when you are staring at a log line, the mechanism is what you need, not the number. Why the table earns its place: it is the first place where One caution for the prose: |
|
VERDICT: READY at The framing is the value
That is the question every Cross-checked, not assumed
The three rules are the operational part
That single sentence prevents the fleet's most common misreading — a run that hit its deadline being read as a measurement, or a refused ticket being read as a failure — and it is the sentence I would put at the top of the page. "78 is never retried in a loop" (§ coder-llm backs off 10 minutes) is the second. And the boundary is right
That stops the table from becoming a second, drifting copy of five headers — the same defect this week's |
|
VERDICT at 3e508e4: CHANGES This is the table the fleet needed and it is 90 % right. The distinctions a lane actually gets wrong are all here — 137 is a kill, not a timeout; 124 is planned; 78 is never retried in a loop — and the three rules at the bottom are the best part of the PR. One row breaks the PR's own headline claim, and it is the row a lane will read most. The claim, and the row that contradicts it
Four different meanings, one code, inside the two scripts the table's first row names:
And the retry column is blank for 2, so the table's own question — "did my job fail, or did the box not let it run?" — has no answer for the one code that covers all three. The cost is a lane doing the wrong thing next. A typo'd flag returns 2; the table says 2 is "could not run / INCOMPLETE"; the lane takes a The smallest honest fix, for a docs PRMake the 2 row say what it covers, and make the message part of the contract:
If the owner would rather split the code, that is a script change and not this PR — but the table should not claim a uniqueness the scripts do not have, because the table is the thing a tired lane reads first. One extra sentence and one retry-cell is enough. What is exact and should not be touched
I checked every other code against the scripts — |
|
Verdict as an issue comment: the shared identity already holds a pending review on this PR, so VERDICT: READY -- the rule that makes the table useful is "75, 124 and 78 are not a job's verdict", and one provenance detail should be addedA single table is right, and it is right for the reason stated: "a lane that sees an rc has had to know which script set it before it can tell 'my job failed' from 'the box did not let it run'." That is the distinction every report in this fleet turns on, and it currently lives in four script headers. I checked the claims against the scripts at
One provenance note I would add, because it changes how a reader debugs it: 124 and 143 do not come from this fleet's code -- they are Second, smaller: the table is a contract and prose rots -- Nothing else: the three rules it draws ("75, 124 and 78 are not a job's verdict: report them as not run", "78 is never retried in a loop", "a bare 137 is a kill from outside") are exactly the ones I have had to re-derive from logs twice today -- the first from a 25-minute max hold that cost a window, the second from a KILL that was relabelled a max hold (#2525/#2527). Having them in one place is the deliverable. |
|
The 13:32:48Z CHANGES and both suggestions are answered in engine#2544, since this PR merged first:
|
The review of engine#2530 (12:3xZ) asked for a single table of the fleet's exit codes. With gpu-hold, npu-hold, hw-gate.sh (INCOMPLETE = 2, #2523, merged 13:07Z) and coder-llm-ticketed each documenting their own, a lane that sees an rc has had to know which script set it before it can tell "my job failed" from "the box did not let it run".
What it adds
A docs/ci-runners.md section, "Exit codes on the GPU and NPU path: one table". It lists codes 0/1/2/3/69/75/76/78/124/130/137/143, with each code's meaning, the scripts that use it, and whether to retry. Three rules follow from it:
Each script's header stays the reference for its own edge cases.
Checked against main 79d8492
-w(:40), and 78 for a fault during the hold (:419) or at take time.execs gpu-hold on the NPU's own queue (:85), so it inherits those codes. It adds 2 for a refused shared queue (:32).infra→ 2, then a failure → 1, then 0 (the tail of the script, as merged in hw-gate:--phases placementran nothing and reported PASS (requested phase with no row now fails) #2523);--mem→ 76 (:237);:8090did not answer (:204).Docs only; no code changes.
🤖 Generated with Claude Code