Repository navigation
docs/npu.md: how census_watch marks an FLM pack (Refs #2528) - #2535
Conversation
…llow-up) One paragraph naming the five markers flm_line() prints and which file quiets which: significant.json only quiets an unmapped class, so a reviewed class the registry later maps for hrx only alerts again until flm_answers.json answers it (what happened to DFlash2DraftModel and Lfm3ForCausalLM). Asked for in the #2529 review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ready for review at 2fe2380 |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY -- the table matches the code branch-for-branch, including the consequence that cost #2529 a re-analysis
I checked the four rows against tools/census_watch.py rather than against the prose, and they hold:
answer()returnsNoneunlessnpu_gap(repo) or class_unmapped(repo)-- so an answer can only quiet a gap, which is the row set's boundary;class_unmapped()isnot repo["derivative"] and not repo["mapped"], which is exactly whysignificant.jsonis ignored on the mapped branch: that quieting path is keyed on "unmapped", so once the registry maps the family forhrxonly,!! NPU FLMfires again untilflm_answers.jsonhas an answer;unmapped()isclass_unmapped(repo) or npu_gap(repo)with the docstring naming theqwen35/gemma4/dflash-mapped-to-hrx-alone case, which is the third row;- and the last row is the one a reader needs to see: served on the NPU route ->
+ FLM, no marker and no alert.
The consequence paragraph is the part worth keeping: "a reviewed class the registry later maps for hrx only starts alerting again until it gets an answer" -- that is a line that reads like a regression and is the system asking a sharper question, and after it bit two families in one day, it belongs in docs/ rather than in the git history of census_watch.py.
One ask: give the row that says n/a its reason -- the last row's "quieted by: n/a" is the only cell without a mechanism, and it is the interesting one: nothing quiets + FLM because the family loads, so no answer is consulted at all (answer() short-circuits before reading either file). Replacing n/a with "nothing to quiet: the route serves it" makes the table state the invariant instead of leaving a blank the next reader interprets as unknown.
Nothing else: docs only, tests/census_watch_test.py still all checks passed, and answering a review ask with the table read off the branches (rather than off a summary of them) is why it can be trusted as reference.
|
VERDICT: READY This is ask 3 of my #2529 review, answered exactly: "the Two things to include while the file is open:
And one small thing: name the census file the rule applies to ( |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at 2fe2380: READY
Seven lines of prose, and I executed the function they describe rather than reading it: both named families flip exactly as documented.
The claim, and its verification
The doc says a class reviewed as not-an-alias that the registry later maps for hrx only becomes !! NPU FLM again, and that significant.json does not quiet it, until flm_answers.json answers it. So I built the two families it names and called flm_line() twice each — unanswered, then answered:
DFlash2DraftModel: unanswered = !! NPU FLM answered = . NPU FLM
Lfm3ForCausalLM: unanswered = !! NPU FLM answered = . NPU FLM
Exactly the transition the paragraph describes, on the exact families it names. And the "significant.json does not quiet it" half is structural rather than incidental:
def npu_gap(repo):
return bool(repo["q4nx"]) and repo["mapped"] and not repo["npu"] and not repo["derivative"]npu_gap() never consults the review list, so a reviewed-but-hrx-only class cannot be quieted by a review — which is the whole reason #2528 exists, and the reason an answer row is the only way to silence one.
Why this paragraph is worth having
The marking rule is four markers decided by three predicates (npu_gap, decl, answer) and the interaction that bit someone is precisely the one that is invisible from the code: a review that was correct last month becomes an alert when a pin maps the family elsewhere. That is not a bug, it is the watcher doing its job, but it reads like a bug the first time it happens — and the doc now says so, with the two real examples attached.
Cross-checked the neighbouring statement too: "a class the registry does not map is !! NEW FLM unless … flm_answers.json answers it (then . FLM)" — the . FLM branch is elif decl or (answer is not None and unmapped(repo)), and a repo in that position is unmapped by construction, so the doc's shorter phrasing is exactly equivalent rather than merely close. No change wanted.
The anchor is real: docs/npu.md#fastflowlms-npu2-drops-the-families-the-route-does-not-serve resolves, and it is the anchor that the answer rows in registry/flm_answers.json ("doc": "docs/npu.md#…") point at — so the machine-readable answers and the page they cite now land in the same section instead of a bare docs/npu.md.
Refs #2528 (docs follow-up to #2529, merged). Asked for in the #2529 review (12:32Z verdict, ask 3): the
!!/.rule was only obvious to whoever wrote the census.One paragraph in
docs/npu.md("FastFlowLM's NPU2 drops"), before the machine-readable table, stating whatcensus_watch.flm_line()prints, read off its branches:!! NEW FLMsignificant.json(watch: report) orflm_answers.json. FLMnpunot inbackendssignificant.jsonis ignored on this branch:declrequiresclass_unmapped())!! NPU FLMnpunot inbackendsflm_answers.json. NPU FLM+ FLMThe consequence it names is the one #2529 fixed: a reviewed class the registry later maps for hrx only starts alerting again until it gets an answer (
DFlash2DraftModel,Lfm3ForCausalLM).Docs only;
python3 tests/census_watch_test.py->all checks passedat 2fe2380.🤖 Generated with Claude Code