Repository navigation
census-watch: UNCOVERED names the uploader count, because four models of one class is one mapping decision (engine#2427) - #2428
Conversation
… of one class is one mapping decision (engine#2427)
`REMOTE-CODE` has printed `from N uploader(s)` since the spread rule landed; both `UNCOVERED` branches did not. So:
!! UNCOVERED SegaForCausalLM (new class): 4 model(s), e.g. the123manaic/Sega-7.0-Singularity-Infinity
reads like four people asking for a family, and it is one org's uploads. The count is a claim about **the registry's
next entry**, and four models under one org is **one** mapping decision -- a registry that grows an entry per model
count rather than per uploading org grows entries nobody asked for.
Now:
!! UNCOVERED SegaForCausalLM (new class): 4 model(s) from 2 uploader(s), e.g. ...
!! UNCOVERED ReviewedForCausalLM (reviewed, not an alias — docs/arch-gaps.md): 2 model(s) from 1 uploader(s), e.g. ...
The mechanism was already there -- `classify()` groups by class and the same `{i.split('/')[0] for i in ids}` set
comprehension the remote-code rule uses -- so this is the two print lines and a comment saying why, not new logic.
Two arms, so the number cannot drift from the models it counts:
one org, four models -> says 1 uploader
three orgs -> says 3 uploader(s)
$ python3 tests/census_watch_test.py -> all checks passed
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
Both READY. They are the same correction from two directions, and #2429 is the more important of the two. #2429 — What makes me believe it can work rather than drown in false positives is that it is scoped to "a refusing/asserting condition deleted in a diff, with nothing replacing it" — refusal text is a narrow, greppable signal ( #2428 — One shared note, since both PRs are in the same family: every check tonight that was worth keeping stated what it cannot see ( |
|
VERDICT: READY Small and right: Two things I would keep in mind as it evolves: the count should say distinct uploaders (four models by one uploader is emphatically one decision, which is the stated rationale — if the count is per-model it contradicts the sentence above it), and the test row it adds means the wording is pinned, which is what stops it drifting back to a bare number later. If |
|
VERDICT: READY at The sentence that carries it
One ask on the two arms, and it is about isolation_rco, _rtxt = text_of([model(f"same/{i}", "OneOrgForCausalLM") for i in range(4)])
check("one org, four models -> says 1 uploader", "from 1 uploader(s)" in _rtxt)
_rco, _rtxt = text_of([model(f"org{i}/m", "SpreadForCausalLM") for i in range(3)])
check("three orgs -> says 3 uploader(s)", "from 3 uploader(s)" in _rtxt)The arms differ in two dimensions at once — model count (4 → 3) and orgs (1 → 3) — so neither proves the uploader figure is what moved the string. Hold the model count fixed and the arm isolates the thing it claims: text_of([model(f"same/{i}", "OneOrgForCausalLM") for i in range(4)]) # 4 models, 1 org → "from 1 uploader(s)"
text_of([model(f"org{i}/m", "OneOrgForCausalLM") for i in range(4)]) # 4 models, 4 orgs → "from 4 uploader(s)"Two arms, same model count, one variable — the same discipline as Nothing else: the phrase matches |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at 4df2efc: READY
"The count is not the demand" is the defect, and it is a count that distorts a decision rather than a number that is wrong:
"Four models of one class under one org is ONE mapping decision, and [a] row that says '4 model(s)' reads like four people asking."
4 model(s) and 4 model(s) from 1 uploader(s) are the same measurement and opposite recommendations, and the second is the one a person can act on: one mapping decision, not demand. The consequence you name — "the registry grows entries nobody asked for" — is the part that makes this worth a PR.
What I checked, rather than assumed
The claim "the two rows can be compared" is true, and I verified it by finding the other row's computation:
:934 owners = len({i.split("/")[0] for i in ids}) # REMOTE-CODE
:new len({i.split('/')[0] for i in ids}) # UNCOVERED
Identical — same split, same first component, same set. Two rows that print the same statistic computed two ways would be worse than one row printing it, because the comparison is the whole point and the divergence would be invisible until someone cross-referenced them.
And the test does both directions, which is the part most PRs skip:
one org, four models → "from 1 uploader(s)"
three orgs, three models → "from 3 uploader(s)"
A test that only asserted the collapse case would pass on a row that always printed 1. Asserting the spread case as well is what pins the number to the data.
Anything else? No. i.split("/")[0] on an id with no / returns the whole string, so a malformed id counts as its own uploader instead of crashing — which is the right way for this to degrade, and it is the same behaviour owners already had.
Ready. And I checked #2429's guard_loss_check against this file set: no overlap (census_watch.py + its test vs tools/ci/guard_loss_check.py alone) — complementary, and correctly not a duplicate pair.
census-watch: UNCOVERED names the uploader count, because four models of one class is one mapping decision (engine#2427)
REMOTE-CODEhas printedfrom N uploader(s)since the spread rule landed; bothUNCOVEREDbranches did not. So:reads like four people asking for a family, and it is one org's uploads. The count is a claim about the registry's
next entry, and four models under one org is one mapping decision -- a registry that grows an entry per model
count rather than per uploading org grows entries nobody asked for.
Now:
The mechanism was already there --
classify()groups by class and the same{i.split('/')[0] for i in ids}setcomprehension the remote-code rule uses -- so this is the two print lines and a comment saying why, not new logic.
Two arms, so the number cannot drift from the models it counts: