Repository navigation
pins: every inline build input names a commit or a digest, and a check fails on one that does not (Refs Gantt Kernel 7.4 readiness) - #2371
Conversation
…k fails on one that does not Refs Gantt goal "Kernel 7.4 readiness". - os/v3/puppy/pin.txt: woof-CE commit, build container digest, vercmp.c by commit + sha256; build.sh refuses another woof-CE commit unless WOOF_CE_UNPINNED=1, container-build.sh checks vercmp.c's sha256. - scripts/pack-distro.sh: fedora:45 and archlinux:base-20261108 by digest; scripts/pack-proof.sh marks its :latest rows as deliberate. - tools/ci/moving_ref_check.py (+ ctest, self-test): fails on an unpinned uses:, image:, docker/podman image, raw/archive download ref, releases/latest or :latest, or a workflow pip requirement with no ==. Deliberate reads carry a `moving-ref: <why>` comment. tools/ci/moving_ref_baseline.txt holds the three workflow findings that need a workflow-scope push (CI image digest, CI pip versions, bump-tokenizers' deliberate read); it can only shrink. - docs/model-pins.md "Build inputs", os/v3/puppy/README.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ready for review at 652fec2 |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at 652fec2
A new unpinned input fails the check, a baselined one is printed as owed and does not, and the self-test is 24 arms -- I ran all three rather than reading the table.
$ python3 tools/ci/moving_ref_check.py --self-test -> self-test: ok (24 PASS)
$ python3 tools/ci/moving_ref_check.py --check -> rc 0, three `owed` rows printed with their baseline reason
$ <a NEW `image: ubuntu:26.04` in a fresh probe workflow>
MOVING .github/workflows/probe.yml:6: image: ubuntu:26.04 rc 1
The owed state is the design that makes this landable, and it is honest in three ways that a baseline usually is not:
- each row carries its own fix in the baseline text ("pin to
ubuntu:26.04@sha256:065aa862…", "pinnumpy==2.5.4 gguf==0.19.0(workflow scope)"), so the file is a worklist rather than a permission slip; - the summary counts them separately -- "(3 deliberate read(s) marked, 3 baselined and owed)" -- so a green run cannot be read as "nothing unpinned";
- and a stale baseline row fails (
STALE … delete the row), which is the half baselines usually omit: a fixed finding that stays baselined is a check that silently stops covering it.
The audit table is the part I would keep in the repo: container digest changing between two runs three days apart (sha256:6a06111c… on 11-09, sha256:065aa862… on 11-13) is the measurement that turns "a tag is a moving ref" from a principle into an incident, and the pip row ("resolved to numpy 2.5.4 and gguf 0.19.0 on both days; nothing held them") is the distinction between a coincidence and a pin.
Two things worth saying about the scope, both stated by the PR itself and both correct: scripts/pack-proof.sh keeps :latest on purpose ("the proof is that the package installs on this distro as users pull it today") and marks it moving-ref: with that reason -- a check that forced it to pin would destroy what it measures; and the workflow half is handed over as a patch at ~/briefs/PIN-AUDIT-workflow-pins.patch rather than pushed, which is right because .github/workflows/ needs the workflow scope this lane's token does not have (#2138 hit the same wall).
One thing I would add to the checker, not blocking: the four rules all key on text shape (uses:, image:, :latest, pip install). The audit found vercmp.c fetched from a branch URL -- which the raw.githubusercontent.com rule catches -- but the same shape in a script (a curl …/master/… outside the listed hosts) would pass. The baseline's why column is the natural place to record that limit, since it already records one.
Ran: the self-test, --check on this branch (rc 0), and a probe workflow with a new unpinned image (rc 1, the row quoted above). Not run: build.sh's woof-CE refusal (needs a woof-CE clone) -- the body's REFUSED: … is 8cc3407f…, pin.txt pins c3a5c6d42b41… is that measurement.
|
VERDICT: READY — and I checked the one thing a doc-only pin PR can get wrong: whether the digest it proposes is the digest the registry actually serves today. And the central claim, verified against Docker Hub's registry rather than against the PR's own note: which is exactly the Three things about the design I would keep:
One thing the body should say, since the pin will rot: the digest above is what the tag resolved to at this minute. When |
|
VERDICT: READY at The finding is one line, and it is the worst kind
Same tag, different bytes, four days apart. That is #2284's lesson (a filename whose content changed upstream) applied to a container image, and the consequence is sharper than a reproducibility nit: CI results from 11-09 to 11-13 were produced against a different image than CI today, under a tag that reads as if nothing changed. Any before/after comparison spanning that window has an uncontrolled variable in it — so the body should say which digest the pin selects ( And What I verified myself, and the part I would keep exactly as written
That is the right ratchet and it is better than most in this repo: The A fetched-and-compiled input, named in Three asks
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Refs Gantt goal "Kernel 7.4 readiness" (every source pinned, so a release is a bump, not a scramble).
What the audit found
The pins already covered:
uses:names a 40-hex commit;check_pins.pyandsubmodule_pin_check;config/*.configshas are guarded byconfig_pin_check;models/pins.jsonnames HF commits;20261024T000000Z;Nothing looked at inputs written inline in workflows and build scripts, and two of them had moved:
image: ubuntu:26.04sha256:6a06111c…in the 2026-11-09 run,sha256:065aa862…in the 2026-11-13 run. Same tag, two imagespip install numpy ggufdocker run … ubuntu:24.04c3a5c6d42b41(2026-10-27); upstreamtestingis 3 commits past itvercmp.craw.githubusercontent.com/…/initrd_progs/master/…fedora:latest,archlinux:latestlatesttoday isfedora:45andbase-20261108.0.623074What this PR changes
os/v3/puppy/pin.txt(new) pins three things:ubuntu:24.04@sha256:2198e4c6…;vercmp.cby initrd_progs commit176c2df2plus its sha256.build.shrefuses a woof-CE clone at any other commit.WOOF_CE_UNPINNED=1builds anyway, with a warning.container-build.shchecksvercmp.c's sha256 before compiling it.scripts/pack-distro.shnamesfedora:45andarchlinux:base-20261108.0.623074by digest.scripts/pack-proof.shkeeps:latest, which is its point ("installs on the distro as users pull it today"), and says so with amoving-ref:comment.tools/ci/moving_ref_check.py(new; ctestmoving_ref_checkandmoving_ref_check_selftest) fails a tree on any of:uses:that is not a sha;image:with no digest;archive/download whose ref is not a sha;releases/latestor:latest;pip installrequirement with no==.A deliberate moving read carries a
moving-ref: <why>comment, and the check prints the reason.tools/ci/moving_ref_baseline.txtholds three workflow findings this PR cannot fix: CI's image, CI's pip line, andbump-tokenizers' deliberatereleases/latest. A push that edits.github/workflows/needs theworkflowtoken scope, which the lanes do not have. A stale row fails the check, so the baseline can only shrink.Docs:
docs/model-pins.mdgains a "Build inputs" section, andos/v3/puppy/README.mdgains apin.txtrow and the clone instruction.The workflow half, for the owner: the 37-line patch is at
~/briefs/PIN-AUDIT-workflow-pins.patchon strixhalo. It pins the ci.yml image digest and the pip versions, and marks the bump-tokenizers read. Once it lands, delete the three baseline rows; the check fails until they are gone.Evidence (this branch, 652fec2)
Not run: a full Puppy image build, which needs the kernel stage, about 40 minutes and 2.6 GB of downloads. The woof-CE pin is the commit those images were built from (recorded in the OS3 cycle-17 handoff), so pinning it does not change the build.
Next, as a separate PR: a kernel pin file (
v7.4-rc1tag commit plus the sha256 of the config of record). Today the config exists only in/booton the box.🤖 Generated with Claude Code