Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,15 @@ an RFC or issue.
project: one label, a request for the bug-report fields when a bug skipped the form, a registry
lookup for linked Hugging Face models, and a pointer to Q&A for questions. The model only picks
the label; every comment is a template. Maintainers can run it on any issue from the Actions tab.
- **A test runs only if a job builds it.** A ctest row is not enough. `ci.yml` builds a fixed `--target` list, so a
target that nothing builds never reaches ctest: hook it with `add_dependencies(onebit <target>)`, the way
`onebit_npu_forward_syntax` is, and `tools/ci/ci_targets_check.py --check` keeps the count from growing. A
`tests/*.sh` script has to be named by a row — or listed with a reason in `tools/ci/unreferenced_tests.txt` if it is
not a row (`anchor_rerun.sh`, an operator measurement that always exits 0) — and `tools/ci/tests_referenced_check.py
--check` fails on one that is referenced by nothing. A row that runs Python goes through `add_python_test()`, which
hands the script to the interpreter instead of relying on the file's exec bit; `tests/python_test_order_check.py
--check` enforces that it follows `find_package(Python3)`. Two rows may not share a name: CMake stops at configure with
`add_test given test NAME "…" which already exists in this directory`.
- **Pins only move forward.** CI fails a pull request whose submodule pin is behind, or has
diverged from, the pin on `main` (`tools/check_pins.py`), because that drops commits the engine
already shipped. A rollback on purpose carries the `pin rollback` label.
Expand Down
Loading