-
Notifications
You must be signed in to change notification settings - Fork 0
[Workflow] Reduce redundant validation and review-cycle latency #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e6470f6
workflow: add focused validation policy and fast check
jjangg96 543b147
fix: close PR74 fast-check review findings
jjangg96 a7d86b2
docs: restore PR72 console head SHA
jjangg96 2ba63c4
fix(workflow): honor Go package patterns and list flags
jjangg96 647c53c
fix(workflow): bound fast test execution flags
jjangg96 9741ce8
Revert "fix(workflow): bound fast test execution flags"
jjangg96 e7c8def
Reapply "fix(workflow): bound fast test execution flags"
jjangg96 7751693
fix(workflow): authenticate focused test execution
jjangg96 91cfbee
fix(workflow): require complete fast test selector
jjangg96 67aafbb
docs: record Go matcher adaptation notice
jjangg96 a78792d
fix(workflow): close fast-check boundary findings
jjangg96 7a560ef
fix(workflow): require framed test execution evidence
jjangg96 d18a115
fix(workflow): retain first framed test terminal outcome
jjangg96 2e1a555
fix(workflow): retain passing match across package runs
jjangg96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
FAST_TESTis supplied using the documented environment-prefix form and contains a nonterminal$, GNU make imports it as a recursively expanded make variable and this export expands the$reference before the script receives it. For example,FAST_TEST='^TestA$.*' make fastpasses^TestA*, which can run and acceptTestBeven though the requested selector only matchedTestA; GNU make's variable-reference rules treat$xas a one-character variable reference. Preserve the raw environment value or require$$escaping for environment assignments too.AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve raw FAST selector values with immediate Make assignments using $(value ...). The regression was already green on this host GNU Make3.81; no pre-fix red is claimed for this finding. Independent review will verify preservation and scope rather than infer resolution from staleness. Candidate a78792d; focused verification selected 19 top-level tests plus 32 subtests using
env GOTOOLCHAIN=go1.26.8 GOWORK=off go test -count=1 ./scripts -run '^(TestFastCheck|TestToolingGOFLAGSUsesGoEnvironment|TestToolingPinsNewerSystemGo)'(PASS, about31s), helper tests PASS. Independent delta review and exact-head CI/Codex remain pending.