Skip to content

fix: problem/batch_association accepts foreign paragraph ids #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Aug 31, 2026
Merged

fix: problem/batch_association accepts foreign paragraph ids #6812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion apps/knowledge/serializers/problem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,25 @@ class BatchAssociation(serializers.Serializer):
child=serializers.UUIDField(required=True, label=_('problem id')))
paragraph_list = AssociationParagraph(many=True)

def is_valid(self, *, knowledge_id=None, raise_exception=False):
super().is_valid(raise_exception=raise_exception)

problem_id_list = self.data.get('problem_id_list')
paragraph_id_list = [str(p.get('id')) for p in self.data.get('paragraph_list')]

self._validate_belong(Problem, problem_id_list, knowledge_id, 'problem id list')
self._validate_belong(Paragraph, paragraph_id_list, knowledge_id, 'paragraph list')

@staticmethod
def _validate_belong(model, id_list, knowledge_id, label):
# 去重,避免重复 id 干扰数量比较
id_set = set(id_list)
exist_count = QuerySet(model).filter(
id__in=id_set, knowledge_id=knowledge_id
).count()
if exist_count != len(id_set):
raise AppApiException(500, f'{label} 中存在不属于当前知识库的数据')


class ProblemSerializers(serializers.Serializer):
class BatchOperate(serializers.Serializer):
Expand Down Expand Up @@ -88,7 +107,8 @@ def delete(self, problem_id_list: List, with_valid=True):
def association(self, instance: Dict, with_valid=True):
if with_valid:
self.is_valid(raise_exception=True)
BatchAssociation(data=instance).is_valid(raise_exception=True)
BatchAssociation(data=instance).is_valid(knowledge_id=self.data.get('knowledge_id'),
raise_exception=True)
knowledge_id = self.data.get('knowledge_id')
paragraph_list = instance.get('paragraph_list')
problem_id_list = instance.get('problem_id_list')
Expand Down
Loading