Report missing datasets executable in download smoke - #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datasetsexecutable as a controlleddatasets_executable_missingdownload-smoke execution blockerdownloads_triggered=0,network_access=false, andexternal_tools=falseRoot cause
A bounded
download-smoke execute --executerun on a machine withoutdatasetsraisedFileNotFoundError, which escaped to the outer CLI error handler and was reported as genericinput_invalid. That made AI controllers treat an environment readiness issue like a malformed command manifest.Validation
python -m pytest tests/test_cli_download_smoke.py -q --basetemp .pytest_tmp_missing_datasets_execute -p no:cacheproviderpython -m pytest tests/test_docs_consistency.py tests/test_docs_hygiene_script.py -q --basetemp .pytest_tmp_missing_datasets_docs -p no:cacheproviderpython scripts/check_workspace_hygiene.pypython scripts/check_docs_hygiene.pygit diff --checkdownload-smoke execute --execute --limit 1returned native exit2, single JSON stdout, wrote execution audit files, and triggered no downloadsBoundaries
No tool installation, provider lookup, broad download, external bioinformatics execution, tag, release, or asset upload was performed.