Skip to content

Add support for TcLibPdf in PdfTestTrait - #42

Open
frankdekker wants to merge 3 commits into
masterfrom
Add-support-for-tc-lib-pdf
Open

Add support for TcLibPdf in PdfTestTrait#42
frankdekker wants to merge 3 commits into
masterfrom
Add-support-for-tc-lib-pdf

Conversation

@frankdekker

@frankdekker frankdekker commented Sep 11, 2026

Copy link
Copy Markdown
Member

Also bumped minimum php version to 8.3. (required by tc-lib-pdf)

@frankdekker
frankdekker marked this pull request as ready for review September 11, 2026 09:28
Copilot AI lite review requested due to automatic review settings September 11, 2026 09:28
@frankdekker
frankdekker requested a review from bram123 September 11, 2026 09:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Keep PHP 8.2 support and corresponding CI coverage unless another dependency requires PHP 8.3.

Pull request overview

Adds tc-lib-pdf support to PdfTestTrait alongside legacy TCPDF support.

Changes:

  • Adds integration tests for tc-lib-pdf.
  • Updates documentation and PHPStan baselines.
  • Adds dependencies and raises the minimum PHP version to 8.3.
  • Updates CI PHP versions.
File summaries
File Description
tests/Integration/Trait/PdfTestTraitTest.php Adds tc-lib-pdf integration tests.
src/Trait/PdfTestTrait.php Supports legacy TCPDF and tc-lib-pdf outputs.
README.md Documents supported PDF engines.
phpstan-baseline.neon Refreshes PHPStan baselines.
composer.json Adds tc-lib-pdf and raises the PHP minimum.
.github/workflows/test.yml Updates CI PHP versions.
Review details

Suppressed comments (1)

composer.json:15

  • tc-lib-pdf 8.73.6 and its tc-lib dependencies declare PHP ^8.2, so this package-level bump to ^8.3 is not required by the selected PDF engine and drops otherwise-supported PHP 8.2 consumers. Please keep the lower bound at ^8.2 and retain the corresponding CI coverage unless another dependency is the actual reason for the breaking change.
        "php": "^8.3",
  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants