Add support for TcLibPdf in PdfTestTrait - #42
Open
frankdekker wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Keep PHP 8.2 support and corresponding CI coverage unless another dependency requires PHP 8.3.
Pull request overview
Adds tc-lib-pdf support to PdfTestTrait alongside legacy TCPDF support.
Changes:
- Adds integration tests for
tc-lib-pdf. - Updates documentation and PHPStan baselines.
- Adds dependencies and raises the minimum PHP version to 8.3.
- Updates CI PHP versions.
File summaries
| File | Description |
|---|---|
tests/Integration/Trait/PdfTestTraitTest.php |
Adds tc-lib-pdf integration tests. |
src/Trait/PdfTestTrait.php |
Supports legacy TCPDF and tc-lib-pdf outputs. |
README.md |
Documents supported PDF engines. |
phpstan-baseline.neon |
Refreshes PHPStan baselines. |
composer.json |
Adds tc-lib-pdf and raises the PHP minimum. |
.github/workflows/test.yml |
Updates CI PHP versions. |
Review details
Suppressed comments (1)
composer.json:15
- tc-lib-pdf 8.73.6 and its tc-lib dependencies declare PHP ^8.2, so this package-level bump to ^8.3 is not required by the selected PDF engine and drops otherwise-supported PHP 8.2 consumers. Please keep the lower bound at ^8.2 and retain the corresponding CI coverage unless another dependency is the actual reason for the breaking change.
"php": "^8.3",
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bram123
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bumped minimum php version to 8.3. (required by tc-lib-pdf)